From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Nanako Shiraishi <nanako3@lavabit.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jay Soffian <jaysoffian@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Switch receive.denyCurrentBranch to "refuse"
Date: Tue, 03 Feb 2009 01:22:05 -0800 [thread overview]
Message-ID: <7v4ozbdgea.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090203080734.GA27251@sigill.intra.peff.net> (Jeff King's message of "Tue, 3 Feb 2009 03:07:34 -0500")
Jeff King <peff@peff.net> writes:
> On Tue, Feb 03, 2009 at 12:01:43AM -0800, Junio C Hamano wrote:
>
>> "To allow pushing into the current branch, you can set it to 'ignore';",
>> - "but this is not recommended unless you really know what you are doing.",
>> + "but this is not recommended unless you arranged its work tree to get",
>> + "updated to match what you pushed in some other way.",
>
> This is much better, but I believe it needs to be "...arranged _for_
> its work tree to get updated..." to be grammatically correct.
>
> And as a nit (which I seem to be full of tonight), you can get rid of
> the passive voice by saying:
>
> but this is not recommended unless you arranged to update its work
> tree to match what you pushed in some other way.
>
> which is slightly more clear, IMHO.
Much more clear. I overuse the passive voice, I know it is a bad habit I
somehow cannot shake off.
Thanks.
next prev parent reply other threads:[~2009-02-03 9:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1233275583u.git.johannes.schindelin@gmx.de>
2009-01-30 0:34 ` [PATCH] Switch receive.denyCurrentBranch to "refuse" Johannes Schindelin
2009-01-30 1:28 ` Jay Soffian
2009-01-30 1:32 ` Asheesh Laroia
2010-04-13 16:42 ` [PATCH] Switch receive.denyCurrentBranch to "refuse" Dave Abrahams
2010-04-13 17:57 ` [PATCH] Switch receive.denyCurrentBranch to "refuse" Junio C Hamano
[not found] ` <7v4ozhd1wp.fsf@gitster.siamese.dyndns.org>
2009-01-30 2:18 ` Junio C Hamano
2009-01-30 13:24 ` Johannes Schindelin
2009-01-30 16:33 ` Jeff King
2009-01-30 16:55 ` Johannes Schindelin
2009-01-30 2:30 ` Miklos Vajna
2009-01-30 13:28 ` Johannes Schindelin
2009-02-11 0:11 ` Miklos Vajna
2009-02-11 1:04 ` Junio C Hamano
2009-01-30 2:55 ` Jeff King
2009-01-30 14:11 ` Johannes Schindelin
2009-01-30 7:17 ` Johannes Sixt
2009-01-30 7:34 ` Jeff King
2009-01-30 13:23 ` Johannes Schindelin
2009-01-30 14:35 ` Jeff King
2009-01-30 16:17 ` Jay Soffian
2009-01-30 16:28 ` Jeff King
2009-01-30 17:01 ` Johannes Schindelin
2009-01-30 18:50 ` Jay Soffian
2009-01-30 19:03 ` Johannes Schindelin
2009-01-31 0:56 ` Nanako Shiraishi
2009-02-01 1:27 ` Junio C Hamano
2009-02-01 1:39 ` Junio C Hamano
2009-02-02 12:41 ` Jeff King
2009-02-03 4:30 ` Junio C Hamano
2009-02-03 17:45 ` Junio C Hamano
2009-02-06 14:06 ` Jeff King
2009-02-07 7:51 ` Junio C Hamano
2009-02-03 8:01 ` Junio C Hamano
2009-02-03 8:07 ` Jeff King
2009-02-03 9:22 ` Junio C Hamano [this message]
2009-02-01 2:06 ` Junio C Hamano
2009-02-01 3:37 ` Sam Vilain
2009-02-01 21:33 ` Junio C Hamano
2009-02-02 7:00 ` Sam Vilain
2009-02-02 8:32 ` Junio C Hamano
2009-02-02 10:50 ` Sam Vilain
2009-02-01 22:59 ` Johannes Schindelin
2009-02-01 23:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4ozbdgea.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=nanako3@lavabit.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.