From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFH] revision limiting sometimes ignored
Date: Sat, 02 Feb 2008 23:47:22 -0800 [thread overview]
Message-ID: <7v4pcqzdkl.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vbq6yzdvr.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Sat, 02 Feb 2008 23:40:40 -0800")
By the way, the issue does not have anything to do with merges.
This is the absolute minimum (and reliable) reproduction recipe.
You need four commits. If you remove "commit three &&", the
traversal will contaminate "one".
---
t/t6009-rev-list-parent.sh | 38 ++++++++++++++++++++++++++++++++++++++
1 files changed, 38 insertions(+), 0 deletions(-)
diff --git a/t/t6009-rev-list-parent.sh b/t/t6009-rev-list-parent.sh
new file mode 100755
index 0000000..1da5dbb
--- /dev/null
+++ b/t/t6009-rev-list-parent.sh
@@ -0,0 +1,38 @@
+#!/bin/sh
+
+test_description='properly cull all ancestors'
+
+. ./test-lib.sh
+
+commit () {
+ test_tick &&
+ echo $1 >file &&
+ git commit -a -m $1 &&
+ git tag $1
+}
+
+test_expect_success setup '
+
+ touch file &&
+ git add file &&
+
+ commit one &&
+
+ test_tick=$(($test_tick - 2400))
+
+ commit two &&
+ commit three &&
+ commit four &&
+
+ git log --pretty=oneline --abbrev-commit
+'
+
+test_expect_failure 'one is ancestor of others and should not be shown' '
+
+ git rev-list one --not four >result &&
+ >expect &&
+ diff -u expect result
+
+'
+
+test_done
next prev parent reply other threads:[~2008-02-03 7:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 12:21 [BUG?] git log picks up bad commit Tilman Sauerbeck
2008-02-03 3:00 ` Jeff King
2008-02-03 4:33 ` [RFH] revision limiting sometimes ignored Jeff King
2008-02-03 6:24 ` Junio C Hamano
2008-02-03 6:39 ` Junio C Hamano
2008-02-03 7:13 ` Jeff King
2008-02-03 7:18 ` Jeff King
2008-02-03 7:40 ` Junio C Hamano
2008-02-03 7:47 ` Junio C Hamano [this message]
2008-02-03 8:18 ` Junio C Hamano
2008-02-04 17:32 ` Linus Torvalds
2008-02-04 17:37 ` Linus Torvalds
2008-02-04 19:08 ` Junio C Hamano
2008-02-04 20:03 ` Linus Torvalds
2008-02-04 20:06 ` Linus Torvalds
2008-02-04 20:50 ` Linus Torvalds
2008-02-05 7:14 ` Junio C Hamano
2008-02-05 21:23 ` Linus Torvalds
2008-02-05 22:34 ` Johannes Schindelin
2008-02-05 23:59 ` Linus Torvalds
2008-02-06 16:43 ` Tilman Sauerbeck
2008-02-06 17:28 ` Nicolas Pitre
2008-02-06 17:42 ` Linus Torvalds
2008-02-06 17:48 ` Nicolas Pitre
2008-02-06 19:26 ` Linus Torvalds
2008-02-06 1:22 ` Nicolas Pitre
2008-02-06 1:51 ` Junio C Hamano
2008-02-06 6:05 ` Junio C Hamano
2008-02-06 6:17 ` Junio C Hamano
2008-02-05 23:44 ` Junio C Hamano
2008-02-06 0:52 ` Linus Torvalds
2008-02-06 5:30 ` Junio C Hamano
2008-02-06 8:16 ` Karl Hasselström
2008-02-06 10:34 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4pcqzdkl.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.