From: Junio C Hamano <gitster@pobox.com>
To: Michael Witten <mfwitten@MIT.EDU>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-send-email: ssh/login style password requests
Date: Fri, 01 Feb 2008 15:34:20 -0800 [thread overview]
Message-ID: <7v4pcs8d4z.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <5F77BB5B-8D2B-42FD-A805-7195757B14EE@mit.edu> (Michael Witten's message of "Fri, 1 Feb 2008 17:42:12 -0500")
Michael Witten <mfwitten@MIT.EDU> writes:
> It turns out that --compose will also leave some temporary files
> behind if git-send-email is terminated out of course.
>
> Should I establish a general handler for SIGTERM and SIGINT?
I was mostly worried about ^C leaving the terminal in a funny
state with your system(stty).
I do not think you should lose the message the user carefully
composed using an editor upon seeing ^C. The user may start to
compose, edit the message, and then at some later time decide to
stop the mail-sending procedure by ^C-ing out. The user would
thank you if you somehow left an escape hatch to allow salvaging
the message, instead of having it to be re-typed from scratch.
next prev parent reply other threads:[~2008-02-01 23:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 4:59 [PATCH] git-send-email: ssh/login style password requests Michael Witten
2008-02-01 10:09 ` Junio C Hamano
2008-02-01 18:38 ` Michael Witten
2008-02-01 22:42 ` Michael Witten
2008-02-01 23:34 ` Junio C Hamano [this message]
2008-02-01 23:42 ` Michael Witten
2008-02-02 1:27 ` Junio C Hamano
2008-02-02 4:06 ` [PATCH 1/2][Perlers?] " Michael Witten
2008-02-02 4:06 ` [PATCH 2/2][Perlers?] git-send-email: SIG{TERM,INT} handlers Michael Witten
2008-02-02 21:31 ` Junio C Hamano
2008-02-02 21:31 ` [PATCH 1/2][Perlers?] git-send-email: ssh/login style password requests Junio C Hamano
2008-02-03 17:59 ` Michael Witten
2008-02-03 20:59 ` Michael Witten
2008-02-04 0:53 ` [PATCH 1/3][V.2] " Michael Witten
2008-02-04 0:53 ` [PATCH 2/3][V.2] git-send-email: SIG{TERM,INT} handlers Michael Witten
2008-02-04 0:53 ` [PATCH 3/3][V.2] git-send-email: Better handling of EOF [^D] Michael Witten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4pcs8d4z.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mfwitten@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.