From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH (amend)] diff: Make numstat machine friendly also for renames (and copies)
Date: Wed, 12 Dec 2007 11:07:40 -0800 [thread overview]
Message-ID: <7v4pen91fn.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200712121131.01471.jnareb@gmail.com> (Jakub Narebski's message of "Wed, 12 Dec 2007 11:31:01 +0100")
Jakub Narebski <jnareb@gmail.com> writes:
> BTW. I have noticed something strange with current (after my two
> patches) diffstat code:
>
> 3606:[gitweb/web@git]# ./git diff-tree -C -C -r --stat gitweb/test~8
> 0456a2ba58efb0e1d5f7421d5a8a2278e3b15ebc
> .../test/file with spaces\tand\ttabs" | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
> 3607:[gitweb/web@git]# ./git diff-tree -C -C -r --numstat gitweb/test~8
> 0456a2ba58efb0e1d5f7421d5a8a2278e3b15ebc
> 3 1 gitweb/test/file with spaces "gitweb/test/file with spaces\tand\ttabs"
If you are wondering about the lack of => in --stat when --numstat is
showing rename, there is nothing strange going on. "filename scaling"
done in --stat happens way later than pprint_rename() in the current
code structure (essentially, it chomps at the last slash to keep the
long "path" fit within the given space). --stat (not --numstat) is for
human consumption and showing longer part of the name of postimage is
more important if we do not have enough room, and most tools that enable
rename use --summary with --stat anyway, so the rename information for
such an oddball long path can be found out elsewhere in the output if
needed.
next prev parent reply other threads:[~2007-12-12 19:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 22:32 [PATCH] diff: Make numstat machine friendly also for renames (and copies) Jakub Narebski
2007-12-10 22:55 ` [PATCH (amend)] " Jakub Narebski
2007-12-11 1:06 ` Junio C Hamano
2007-12-11 1:26 ` Jakub Narebski
2007-12-11 2:50 ` Junio C Hamano
2007-12-11 23:09 ` Jakub Narebski
2007-12-12 7:46 ` Junio C Hamano
2007-12-12 10:21 ` Jakub Narebski
2007-12-12 10:31 ` Jakub Narebski
2007-12-12 19:07 ` Junio C Hamano [this message]
2007-12-10 23:00 ` [PATCH] " Junio C Hamano
2007-12-10 23:14 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4pen91fn.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.