All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com,
	Johan Herland <johan@herland.net>
Subject: Re: [PATCH] Introduce light weight commit annotations
Date: Sun, 10 Jun 2007 15:11:35 -0700	[thread overview]
Message-ID: <7v4plf7948.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0706091854330.4059@racer.site> (Johannes Schindelin's message of "Sat, 9 Jun 2007 18:55:10 +0100 (BST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> With the provided script, edit-commit-annotations, you can add
> after-the-fact annotations to commits, which will be shown by
> the log if the config variable core.showannotations is set.
>
> The annotations are tracked in a new ref, refs/annotations/commits,
> in the same fan-out style as .git/objects/??/*, only that they only
> exist in the object database now.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>
> 	I have the hunch that this will be relatively fast and scalable,
> 	since the tree objects are sorted by name (the name being the
> 	object name of the to-be-annotated commit).

The entries of tree are sorted but not necessarily of uniform
length so you end up needing linear search anyway.  The fan-out
would help with the current tree objects.

It will hurt _if_ we introduce a new tree object format that
would give you a quick random-access at an entry, but it is
premature to worry about that now.

  parent reply	other threads:[~2007-06-10 22:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-09 17:55 [PATCH] Introduce light weight commit annotations Johannes Schindelin
2007-06-10 13:14 ` Johan Herland
2007-06-10 18:56   ` Johannes Schindelin
2007-06-10 19:20     ` Johan Herland
2007-06-10 19:53       ` Johannes Schindelin
2007-06-10 22:11 ` Junio C Hamano [this message]
2007-06-10 23:00   ` Johannes Schindelin
2007-06-10 23:29     ` Junio C Hamano
2007-06-11 10:25       ` Johannes Schindelin
2007-06-12 17:28       ` Johannes Schindelin
2007-06-10 22:58 ` Alex Riesen
2007-06-10 23:20 ` Alex Riesen
2007-06-11  1:11   ` Junio C Hamano
2007-06-11  2:09 ` Nicolas Pitre
2007-06-11  7:24   ` Alex Riesen
2007-06-11  7:43     ` Junio C Hamano
2007-06-11  8:05       ` Alex Riesen
2007-06-11 10:22   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4plf7948.fsf@assigned-by-dhcp.cox.net \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=johan@herland.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.