From: Junio C Hamano <junkio@cox.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Andreas Fuchs <asf@boinkor.net>,
Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH] gitweb: Atom feeds
Date: Fri, 17 Nov 2006 01:01:05 -0800 [thread overview]
Message-ID: <7v4psysazy.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <ejim5q$31b$1@sea.gmane.org> (Andreas Fuchs's message of "Thu, 16 Nov 2006 22:45:25 +0100")
Andreas Fuchs <asf@boinkor.net> writes:
> Jakub Narebski wrote:
>> Andreas Fuchs <asf@boinkor.net> wrote:
>>
>>> * Wrap the commit message in <pre>
>> We use <div class="pre"> in "commit" view if I remember correctly.
>
> That's ok for rendered HTML output, but in my experience, the way feed
> readers interpret that ranges from "badly" to "not at all"; it's better
> to stick to explicit structure hints only in feeds. /-:
>
> So, this is the only thing I haven't fixed in the attached patch (:
> ...
> In addition to the above points, the attached patch emits a
> Last-Changed: HTTP response header field, and doesn't compute the feed
> body if the HTTP request type was HEAD. This helps keep the web server
> load down for well-behaved feed readers that check if the feed needs
> updating.
>
> Hope you like it,
Seems sane to me. Jakub, how do you like this one? If it looks
Ok to you, please arrange to include your one-liner that this
depends on and forward a readily applicable patch with
appropriate commit log message.
next prev parent reply other threads:[~2006-11-17 9:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 0:10 [PATCH] gitweb: Make RSS feed output prettier asf
2006-11-15 0:24 ` Jakub Narebski
2006-11-16 21:45 ` [PATCH] gitweb: Atom feeds (was: gitweb: Make RSS feed output prettier) Andreas Fuchs
2006-11-17 9:01 ` Junio C Hamano [this message]
2006-11-17 11:36 ` [PATCH] gitweb: Atom feeds Jakub Narebski
2006-11-19 14:05 ` [PATCH 1/2] gitweb: Add an option to href() to return full URL Jakub Narebski
2006-11-19 14:05 ` [PATCH 2/2] gitweb: Refactor feed generation, make output prettier, add Atom feed Jakub Narebski
2006-11-20 14:45 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4psysazy.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=asf@boinkor.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.