All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Ingo Brückl" <ib@wupperonline.de>, git@vger.kernel.org
Subject: Re: [PATCH] Fix wrong failures in config test
Date: Mon, 10 Jan 2011 13:30:12 -0800	[thread overview]
Message-ID: <7v62tw5twb.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110110194242.GA11801@burratino> (Jonathan Nieder's message of "Mon\, 10 Jan 2011 13\:42\:42 -0600")

Jonathan Nieder <jrnieder@gmail.com> writes:

>> Unfortunately, I had a shell alias function named git that interfered. In
>> fact it passes to the git program (command git "$@") but sadly does not know
>> about the newly set PATH and (still inexplicably to me) makes the variable
>> set.

Yuck.  I really do not want to do something like this X-<.

 t/test-lib.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/test-lib.sh b/t/test-lib.sh
index cb1ca97..df1b4f2 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -77,10 +77,10 @@ export GIT_COMMITTER_EMAIL GIT_COMMITTER_NAME
 export EDITOR
 
 # Protect ourselves from common misconfiguration to export
-# CDPATH into the environment
+# CDPATH into the environment and such
 unset CDPATH
-
 unset GREP_OPTIONS
+unalias git >/dev/null 2>&1 || :
 
 case $(echo $GIT_TRACE |tr "[A-Z]" "[a-z]") in
 	1|2|true)

  reply	other threads:[~2011-01-10 21:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10 16:13 [PATCH] Fix wrong failures in config test Ingo Brückl
2011-01-10 16:52 ` Jonathan Nieder
2011-01-10 17:15   ` Ingo Brückl
2011-01-10 17:29     ` Jonathan Nieder
2011-01-10 18:30 ` Junio C Hamano
2011-01-10 19:21   ` Ingo Brückl
2011-01-10 19:42     ` Jonathan Nieder
2011-01-10 21:30       ` Junio C Hamano [this message]
2011-01-10 21:33         ` Jonathan Nieder
2011-01-10 21:50         ` Ingo Brückl
     [not found]       ` <4d2b7b68.47102a21.bm000@wupperonline.de>
2011-01-10 21:59         ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v62tw5twb.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ib@wupperonline.de \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.