From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Teemu Likonen <tlikonen@iki.fi>, git@vger.kernel.org
Subject: Re: "add -p" + filenames with UTF-8 multibyte characters = "No changes"
Date: Sun, 15 Feb 2009 20:00:03 -0800 [thread overview]
Message-ID: <7v63jbf2v0.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090216033634.GA12461@coredump.intra.peff.net> (Jeff King's message of "Sun, 15 Feb 2009 22:36:34 -0500")
Jeff King <peff@peff.net> writes:
> But what is the right encoding to specify? We can guess that it is
> whatever the commit message is in (defaulting to utf-8). It is by no
> means correct, but it would probably work pretty well in practice.
>
> On the other hand, we already have the same problem for encoded file
> _contents_. So maybe it is not a big problem in practice.
I did not spell the specifics out because this change won't happen in any
near future anyway, but my thinking was to give a way for "add -p" to
either (1) internally run without quotepath regardless of the user's
settings or (2) unquote the paths correctly when it learns the set of
paths affected by the change.
I think the right approach is (2), because you need to unquote pathnames
with some byte values that even with core.quotepath=false will not pass
unquoted *anyway*.
I also happen to think that it may be a good idea to ignore core.quotepath
settings in format-patch, but that is a separate topic.
next prev parent reply other threads:[~2009-02-16 4:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 18:40 "add -p" + filenames with UTF-8 multibyte characters = "No changes" Antonio García Domínguez
2009-02-15 18:59 ` Teemu Likonen
[not found] ` <2b8265360902151100n2eca0182odf9543c1dd8a7f98@mail.gmail.com>
2009-02-15 19:11 ` Teemu Likonen
2009-02-16 3:36 ` Jeff King
2009-02-16 4:00 ` Junio C Hamano [this message]
2009-02-17 7:02 ` [PATCH] git-add -i/-p: learn to unwrap C-quoted paths Junio C Hamano
2009-02-17 8:09 ` Teemu Likonen
2009-02-16 5:13 ` "add -p" + filenames with UTF-8 multibyte characters = "No changes" Teemu Likonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63jbf2v0.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=tlikonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.