From: Junio C Hamano <gitster@pobox.com>
To: Kjetil Barvik <barvik@broadpark.no>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c
Date: Sun, 11 Jan 2009 14:25:34 -0800 [thread overview]
Message-ID: <7v63klpjj5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <86ab9x8t4a.fsf@broadpark.no> (Kjetil Barvik's message of "Sun, 11 Jan 2009 21:50:29 +0100")
Kjetil Barvik <barvik@broadpark.no> writes:
> And the 'a' and the 'd' in the DCO I do agree with in this particular
> situation, so I added a '--signoff' to the patches.
I think Dscho's suggestion was to sign-off when you commit, not when you
format-patch. It won't make any difference either way to me nor other
people who reads the list, because nobody can tell which way you used by
looking at your e-mail, but it is a good habit to get into if you work on
git or the kernel.
next prev parent reply other threads:[~2009-01-11 22:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 18:36 [PATCH] Cleanup of unused symcache variable inside diff-lib.c Kjetil Barvik
2009-01-11 18:45 ` Johannes Schindelin
2009-01-11 19:32 ` Kjetil Barvik
2009-01-11 19:46 ` Johannes Schindelin
2009-01-11 20:09 ` Kjetil Barvik
2009-01-11 20:17 ` Johannes Schindelin
2009-01-11 20:50 ` Kjetil Barvik
2009-01-11 22:25 ` Junio C Hamano [this message]
2009-01-11 22:23 ` Junio C Hamano
2009-01-12 5:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63klpjj5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barvik@broadpark.no \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.