From: Junio C Hamano <junio@pobox.com>
To: drafnel@gmail.com
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/5] Make mktag a builtin.
Date: Sun, 11 May 2008 10:28:09 -0700 [thread overview]
Message-ID: <7v63tk6992.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7689656.1210299528037.JavaMail.teamon@b301.teamon.com> (drafnel@gmail.com's message of "Thu, 8 May 2008 21:19:46 -0500")
drafnel@gmail.com writes:
> From: Brandon Casey <drafnel@gmail.com>
>
> Signed-off-by: Brandon Casey <drafnel@gmail.com>
> @@ -306,6 +305,7 @@ BUILT_INS += git-fsck-objects$X
> BUILT_INS += git-get-tar-commit-id$X
> BUILT_INS += git-init$X
> BUILT_INS += git-merge-subtree$X
> +BUILT_INS += git-mktag$X
> BUILT_INS += git-peek-remote$X
> BUILT_INS += git-repo-config$X
> BUILT_INS += git-show$X
> @@ -423,6 +423,7 @@ LIB_OBJS += log-tree.o
> LIB_OBJS += mailmap.o
> LIB_OBJS += match-trees.o
> LIB_OBJS += merge-file.o
> +LIB_OBJS += mktag.o
This is unusual for a builtin. Why didn't it migrate to builtin-mktag?
next prev parent reply other threads:[~2008-05-11 17:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1210299589-10448-1-git-send-email-drafnel@example.com>
2008-05-09 2:19 ` [PATCH 1/5] mktag.c: adjust verify_tag parameters drafnel
2008-05-11 18:39 ` Junio C Hamano
2008-05-12 15:43 ` Brandon Casey
[not found] ` <1210299589-10448-2-git-send-email-drafnel@example.com>
2008-05-09 2:19 ` [PATCH 2/5] Make mktag a builtin drafnel
2008-05-11 17:28 ` Junio C Hamano [this message]
2008-05-11 17:36 ` Junio C Hamano
2008-05-12 15:09 ` Brandon Casey
2008-05-12 17:04 ` Johannes Schindelin
2008-05-12 17:32 ` Brandon Casey
2008-05-12 18:41 ` Junio C Hamano
[not found] ` <1210299589-10448-3-git-send-email-drafnel@example.com>
2008-05-09 2:19 ` [PATCH 3/5] mktag.c: rename verify_tag to verify_tag_buffer drafnel
[not found] ` <1210299589-10448-4-git-send-email-drafnel@example.com>
2008-05-09 2:19 ` [PATCH 4/5] mktag.c: consolidate tag functions by merging mktag.c into builtin-tag.c drafnel
[not found] ` <1210299589-10448-5-git-send-email-drafnel@example.com>
2008-05-09 2:19 ` [PATCH 5/5] git-tag: call verify_tag_buffer to validate the generated tag object drafnel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v63tk6992.fsf@gitster.siamese.dyndns.org \
--to=junio@pobox.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.