All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] Re: cosmetic improvements for "git show tag"
Date: Sun, 19 Jul 2009 11:05:16 -0700	[thread overview]
Message-ID: <7v7hy4y2eb.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20090718101436.GA22535@coredump.intra.peff.net> (Jeff King's message of "Sat\, 18 Jul 2009 06\:14\:37 -0400")

Jeff King <peff@peff.net> writes:

> The code calls into log_tree_commit, which uses the "shown_one" member
> of rev_info to determine. So we should be able to just use that for our
> tags, and everything will work fine.
>
> I think we can replace 2/2 with the patch below, which also covers the
> tree case neatly.

Ack.  Looks sane.

Thanks.

      reply	other threads:[~2009-07-19 18:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 23:16 [PATCH 0/2] cosmetic improvements for "git show tag" Jeff King
2009-07-17 23:18 ` [PATCH 1/2] show: suppress extra newline when showing annotated tag Jeff King
2009-07-18  3:25   ` [PATCH 1/2] " Nicolas Sebrecht
2009-07-18  3:47     ` Jeff King
2009-07-17 23:22 ` [PATCH 2/2] show: add space between tag body and tagged object Jeff King
2009-07-18  1:10 ` [PATCH 0/2] Re: cosmetic improvements for "git show tag" Nicolas Sebrecht
2009-07-18  1:47   ` Jeff King
2009-07-18 10:14     ` Jeff King
2009-07-19 18:05       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7hy4y2eb.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=nicolas.s.dev@gmx.fr \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.