All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: nathan spindel <nathans@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] instaweb: make it compatible with Mac OS X 10.5's apache installation.
Date: Mon, 12 May 2008 11:42:03 -0700	[thread overview]
Message-ID: <7v7idzz7no.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 200805121952.55492.chriscool@tuxfamily.org

Christian Couder <chriscool@tuxfamily.org> writes:

> Maybe you can use a function like this not tested one:
>
> check_cmd() {
> 	cmd="$1"
>
> 	if type "$cmd" > /dev/null 2>&1; then
> 		if "$cmd" -v | grep Apache > /dev/null 2>&1; then
> 			httpd=$(echo "$cmd" | sed "s/apache2/httpd/")
> 		fi
> 	fi
> }

One worry I have with that approach is if any and all random
implementations of "httpd" that live somewhere in path do not do any harm
when started with "-v" option.  Namely, they should exit without becoming
a daemon and/or start the service.

I am not convinced that would be the case.

  reply	other threads:[~2008-05-12 18:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-11 19:36 [PATCH v2] instaweb: make it compatible with Mac OS X 10.5's apache installation nathan spindel
2008-05-11 19:41 ` nathan spindel
2008-05-12 17:52   ` Christian Couder
2008-05-12 18:42     ` Junio C Hamano [this message]
2008-05-13  2:54       ` nathan spindel
2008-05-13 12:30         ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7idzz7no.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=nathans@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.