From: Junio C Hamano <gitster@pobox.com>
To: "Ping Yin" <pkufranky@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] fix "diff --raw" on the work tree side
Date: Sun, 02 Mar 2008 09:11:25 -0800 [thread overview]
Message-ID: <7v7igloxtu.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 46dff0320803020241l29277bd4m1a711ff0a863e7f8@mail.gmail.com
"Ping Yin" <pkufranky@gmail.com> writes:
> On Sun, Mar 2, 2008 at 5:43 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> The second patch fixes the inconsistency between "git-diff --raw" and
>> "git-diff-{index,files} --raw" when they are used for submodules.
>>
>> The third one is a bit controversial and changes the semantics and
>> existing callers and won't be considered for 1.5.5.
>>
> Unfortunately, my submodule summary patch series will depend on
> git-diff or git-diff-index. So should i resend my improved patch only
> after the thrid one is applied?
I do not think re-introducing the inconsistency like the third one does is
a palatable option.
Wouldn't grabbing (cd $submodule && git rev-parse HEAD) yourself be more
portable across git before and after the bugfix of "git diff --raw"?
next prev parent reply other threads:[~2008-03-02 17:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-02 9:43 [PATCH 0/3] fix "diff --raw" on the work tree side Junio C Hamano
2008-03-02 9:43 ` [PATCH 1/3] diff-lib.c: constness strengthening Junio C Hamano
2008-03-02 9:43 ` [PATCH 2/3] diff: make sure work tree side is shown as 0{40} when different Junio C Hamano
2008-03-02 9:43 ` [PATCH 3/3] diff: show submodule object name when available even on the work tree side Junio C Hamano
2008-03-02 10:41 ` [PATCH 0/3] fix "diff --raw" " Ping Yin
2008-03-02 17:11 ` Junio C Hamano [this message]
2008-03-02 17:15 ` Ping Yin
2008-03-02 17:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7igloxtu.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pkufranky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.