All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: David Symonds <dsymonds@gmail.com>,
	git@vger.kernel.org, Andreas Ericsson <ae@op5.se>
Subject: Re: [NEW REPLACEMENT PATCH] git-checkout: Add a test case for relative paths use.
Date: Thu, 08 Nov 2007 12:48:37 -0800	[thread overview]
Message-ID: <7v7iks31lm.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0711081427450.4362@racer.site> (Johannes Schindelin's message of "Thu, 8 Nov 2007 14:32:52 +0000 (GMT)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> +	mkdir dir2 &&
>> +	echo bonjour > dir2/file2 &&
>> +	git add dir2/file2 &&
>> +	git commit -m "populate tree"
>> +
>> +'
>
> Please lose the empty line before the closing quote.  (This applies to all 
> tests.)

I personaly find the extra blank lines before and after the
indented test body easier to read.  That is..


	test_expect_sucess 'test description comes here' '

		test command 1 &&
		test command 2 &&
                ...
                test command N

	'

I agree with all other suggestions from your message.

  reply	other threads:[~2007-11-08 20:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-08 13:13 [NEW REPLACEMENT PATCH] git-checkout: Add a test case for relative paths use David Symonds
2007-11-08 14:32 ` Johannes Schindelin
2007-11-08 20:48   ` Junio C Hamano [this message]
2007-11-08 23:04     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7iks31lm.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=ae@op5.se \
    --cc=dsymonds@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.