All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jari Aalto <jari.aalto@cante.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Explain in --pid-file that using --inetd implies it automatically
Date: Wed, 29 Aug 2007 03:23:54 -0700	[thread overview]
Message-ID: <7v7iner64l.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <zm0a1vw9.fsf@cante.net> (Jari Aalto's message of "Wed, 29 Aug 2007 13:24:06 +0300")

Jari Aalto <jari.aalto@cante.net> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>>> -	Save the process id in 'file'.
>>> +	Save the process id in 'file'. When `--inetd` is in use, this
>>> +        option is not needed.
>>
>> Is it "is not needed"?  I think you meant to say "is ignored",
>> IOW, no pid file is written.
>
> Corrected
>
>     git repository http://cante.net/~jaalto/git/git
>     Branch: git-daemon.txt+option--pid-file.collapse
>
>  Documentation/git-daemon.txt |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

Phuleeeze.  Try to apply what you sent out with "git am" and
watch the resulting commit log message in horrors!

Hint. "Documentation/SubmittingPatches".

Thanks.  I'll do this by hand so no need to resend.

>
> diff --git a/Documentation/git-daemon.txt b/Documentation/git-daemon.txt
> index f902161..861d68f 100644
> --- a/Documentation/git-daemon.txt
> +++ b/Documentation/git-daemon.txt
> @@ -124,7 +124,8 @@ OPTIONS
>         Detach from the shell. Implies --syslog.
>  
>  --pid-file=file::
> -       Save the process id in 'file'.
> +       Save the process id in 'file'. When `--inetd` is in use, this
> +        option is ignored.
>  
>  --user=user, --group=group::
>         Change daemon's uid and gid before entering the service loop.

  reply	other threads:[~2007-08-29 10:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-29  8:07 [PATCH] Explain in --pid-file that using --inetd implies it automatically Jari Aalto
2007-08-29  8:17 ` Junio C Hamano
2007-08-29 10:24   ` Jari Aalto
2007-08-29 10:23     ` Junio C Hamano [this message]
2007-08-29 10:33     ` [PATCH] git-daemon(1): assorted improvements Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v7iner64l.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jari.aalto@cante.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.