All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Robin Rosenberg <robin.rosenberg.lists@dewire.com>,
	git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH] Make repack less likely to corrupt repository
Date: Thu, 19 Feb 2009 16:09:30 -0800	[thread overview]
Message-ID: <7v8wo2klz9.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0902192337040.6223@intel-tinevez-2-302> (Johannes Schindelin's message of "Thu, 19 Feb 2009 23:44:37 +0100 (CET)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> +for name in $names
>> +do
>> +	rm -f "$PACKDIR/old-pack-$name.idx"
>> +	rm -f "$PACKDIR/old-pack-$name.pack"
>> +done
>> +
>> +# End of pack replacement.
>
> Is this comment really needed here?

Is that hunk still needed?  I think the removal part is already there all
the way down to maint.

Other than that, I think your comments are all sane.

  reply	other threads:[~2009-02-20  0:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-09  0:44 [PATCH] Make repack less likely to corrupt repository Robin Rosenberg
2009-02-09  6:04 ` Junio C Hamano
2009-02-10  7:07   ` Robin Rosenberg
2009-02-10 15:59     ` Junio C Hamano
2009-02-10 16:57       ` Robin Rosenberg
2009-02-10 20:16         ` Junio C Hamano
2009-02-10 23:51           ` Robin Rosenberg
2009-02-10 23:56             ` Junio C Hamano
2009-02-11  0:27               ` Robin Rosenberg
2009-02-11  0:31                 ` Junio C Hamano
2009-02-11 17:08                   ` Robin Rosenberg
2009-02-15 16:15                   ` Robin Rosenberg
2009-02-15 16:46                     ` Johannes Schindelin
2009-02-15 18:42                       ` Robin Rosenberg
2009-02-15 20:09                         ` Junio C Hamano
2009-02-16  5:17                           ` Robin Rosenberg
2009-02-19 22:21                           ` Robin Rosenberg
2009-02-19 22:44                             ` Johannes Schindelin
2009-02-20  0:09                               ` Junio C Hamano [this message]
2009-02-20  0:09                               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8wo2klz9.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=robin.rosenberg.lists@dewire.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.