All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junio@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: David Symonds <dsymonds@gmail.com>,
	Brian Gernhardt <benji@silverinsanity.com>,
	Jon Smirl <jonsmirl@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	gitster@pobox.com
Subject: Re: [PATCH 2/2] git status: show relative paths when run in a subdirectory
Date: Thu, 08 Nov 2007 00:26:16 -0800	[thread overview]
Message-ID: <7v8x593zyv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0711080011170.4362@racer.site> (Johannes Schindelin's message of "Thu, 8 Nov 2007 00:12:22 +0000 (GMT)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> -static const char *quote_crlf(const char *in, char *buf, size_t sz)
> +static const char *quote_crlf(const char *in, int len, char *buf, size_t sz,
> +	const char *prefix)
>  {

This is not quote_*crlf* anymore.

> @@ -118,8 +150,8 @@ static void wt_status_print_filepair(struct wt_status *s,
>  	const char *one, *two;
>  	char onebuf[PATH_MAX], twobuf[PATH_MAX];
>  
> -	one = quote_crlf(p->one->path, onebuf, sizeof(onebuf));
> -	two = quote_crlf(p->two->path, twobuf, sizeof(twobuf));
> +	one = quote_crlf(p->one->path, -1, onebuf, sizeof(onebuf), s->prefix);
> +	two = quote_crlf(p->two->path, -1, twobuf, sizeof(twobuf), s->prefix);

I wonder if it makes more sense to use strbuf here...

  parent reply	other threads:[~2007-11-08  8:26 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 22:15 Inconsistencies with git log Jon Smirl
2007-11-07 22:42 ` Johannes Schindelin
2007-11-07 22:45   ` Jon Smirl
2007-11-07 22:58     ` Johannes Schindelin
2007-11-07 23:03       ` Jon Smirl
2007-11-07 23:11         ` Johannes Schindelin
2007-11-07 23:16           ` Jon Smirl
2007-11-07 23:29           ` Jon Smirl
2007-11-08  0:04             ` Johannes Schindelin
2007-11-08  0:09               ` Jon Smirl
2007-11-08  0:16                 ` Andreas Ericsson
2007-11-08  0:35                 ` Johannes Schindelin
2007-11-09 15:54                 ` Linus Torvalds
2007-11-09 17:20                   ` Jon Smirl
2007-11-09 17:38                     ` Linus Torvalds
2007-11-09 17:53                       ` Linus Torvalds
2007-11-09 18:04                         ` Jon Smirl
2007-11-09 18:14                           ` Linus Torvalds
2007-11-09 18:22                         ` Peter Baumann
2007-11-09 18:35                           ` Junio C Hamano
2007-11-09 18:37                             ` Jakub Narebski
2007-11-09 18:39                             ` Peter Baumann
2007-11-09 18:36                           ` Linus Torvalds
2007-11-09 17:41                     ` Jakub Narebski
2007-11-08  9:24             ` Wincent Colaiuta
2007-11-08 18:28             ` Daniel Barkalow
2007-11-07 23:19         ` Brian Gernhardt
2007-11-07 23:31           ` David Symonds
2007-11-08  0:09             ` Johannes Schindelin
2007-11-08  0:14               ` David Symonds
2007-11-08  0:52                 ` Brian Gernhardt
2007-11-08  0:10             ` [PATCH 1/2] Makefile: wt-status.h is also a lib header Johannes Schindelin
2007-11-08  0:11             ` Inconsistencies with git log Andreas Ericsson
2007-11-08  8:29               ` Peter Baumann
2007-11-08 13:16               ` David Symonds
2007-11-08 13:40                 ` Andreas Ericsson
2007-11-08 21:21                 ` Alex Riesen
2007-11-08 21:23                   ` Alex Riesen
2007-11-08  0:12             ` [PATCH 2/2] git status: show relative paths when run in a subdirectory Johannes Schindelin
2007-11-08  0:53               ` David Symonds
2007-11-08  1:00                 ` Johannes Schindelin
2007-11-08  8:26               ` Junio C Hamano [this message]
2007-11-09 15:30                 ` [PATCH REPLACEMENT for " Johannes Schindelin
2007-11-10 12:08                   ` Michel Marti
2007-11-10 14:10                     ` Johannes Schindelin
2007-11-08  9:19         ` Inconsistencies with git log Wincent Colaiuta
2007-11-10 22:51         ` Miles Bader
2007-11-07 23:00     ` David Symonds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8x593zyv.fsf@gitster.siamese.dyndns.org \
    --to=junio@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=benji@silverinsanity.com \
    --cc=dsymonds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonsmirl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.