All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] log: test for regression introduced in v1.7.2-rc0~103^2~2
Date: Sun, 15 Aug 2010 18:49:43 -0700	[thread overview]
Message-ID: <7vaaonfhs8.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTi=PAW_Owy_-DSQ32sboB28373Gb_aySbpeprwLg@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sun\, 15 Aug 2010 09\:24\:16 +0000")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>>> +     # Needs an unrelated root commit
>>> +     test_commit README &&
>>
>> This is not a "root" commit, is it?
>
> s/root/first/

It is not even the first commit, is it?  It comes on top of whatever
commits that earlier tests left.

>>> +     >Foo.bar &&
>>> +     git add Foo.bar &&
>>> +     git commit --allow-empty-message </dev/null &&
>>
>> Does emptiness of the message matter?
>
> No, I was just going for a minimal test case, no commit message is
> more minimal than having one.

I do not think having to write "--allow-empty-message </dev/null" is
aiming for being minimal; it is doing something unusual after all.

If you do not remember why you added this test 6 months down the road,
wouldn't you be confused to think maybe the commit has to be unusual in
that it has to lack the message to trigger the bug?

  reply	other threads:[~2010-08-16  1:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13 11:25 BUG: git log: fatal: internal error in diff-resolve-rename-copy Constantine Plotnikov
2010-08-13 13:38 ` Ævar Arnfjörð Bjarmason
2010-08-13 17:36 ` Junio C Hamano
2010-08-13 17:53   ` Linus Torvalds
2010-08-13 19:12   ` Junio C Hamano
2010-08-13 19:46     ` [PATCH] diff --follow: do call diffcore_std() as necessary Junio C Hamano
2010-08-13 21:27       ` Ævar Arnfjörð Bjarmason
2010-08-13 22:46         ` Junio C Hamano
2010-08-14  1:10           ` [PATCH] log: test for regression introduced in v1.7.2-rc0~103^2~2 Ævar Arnfjörð Bjarmason
2010-08-14  1:19             ` Ævar Arnfjörð Bjarmason
2010-08-15  9:08               ` Junio C Hamano
2010-08-15  9:24                 ` Ævar Arnfjörð Bjarmason
2010-08-16  1:49                   ` Junio C Hamano [this message]
2010-08-16  2:01                     ` Ævar Arnfjörð Bjarmason
2010-08-15 10:16                 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-08-17 14:48     ` BUG: git log: fatal: internal error in diff-resolve-rename-copy Constantine Plotnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vaaonfhs8.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.