Re: [PATCH] config: --replace-all with one argument exits properly with a better message.

[Junio C Hamano <gitster@pobox.com>]

Felipe Contreras <felipe.contreras@gmail.com> writes:

> On Sat, Mar 14, 2009 at 10:53 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Carlos Rica <jasampler@gmail.com> writes:
>>
>>> 'config --replace-all ONE_ARG' was being treated as 'config NAME VALUE',
>>> showing the error "key does not contain a section: --replace-all".
>>
>> Hmm, I am getting "error: wrong number of arguments" followed by the long
>> and somewhat annoying "usage" from the parseopt table dump.
>
> If you find it annoying why don't you remove the usage?

Because the primary target audience of the help text is not me?

>> Can you work with Felipe to see if this is still needed, or needs to be
>> fixed in a different way?  It could be that your tests may already pass
>> over there on 'next'.  I didn't check.
>
> The new code is already checking correctly that --replace-all needs at
> least two arguments. However, the "usage" is incorrect and of course
> the test will come in handy.

So perhaps you can pick a part of it and send in an update to your
parseoptification series?  I think the series is ready for 'master'
sometime next week if not sooner.