From: Junio C Hamano <gitster@pobox.com>
To: Jonas Fonseca <fonseca@diku.dk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Improve and fix git-check-attr(1)
Date: Tue, 14 Oct 2008 16:58:08 -0700 [thread overview]
Message-ID: <7vabd6686n.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081013175705.GA9538@diku.dk> (Jonas Fonseca's message of "Mon, 13 Oct 2008 19:57:05 +0200")
Jonas Fonseca <fonseca@diku.dk> writes:
> Always use 'verse' for multi-line synopsis sections. Add output and
> example sections to document what output can be expected.
>
> Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
>
> ---
> Documentation/git-check-attr.txt | 63 +++++++++++++++++++++++++++++++++++++-
> 1 files changed, 62 insertions(+), 1 deletions(-)
>
> At least the first chunk should be applied. The last is a quick attempt
> at documenting the expected output formally and with examples.
> ...
> tg: (340fcf4..) jf/man-git-check-attr (depends on: next)
Should this really have to depend on next? I have a feeling that a large
part of this (sans --stdin/-z) is a 'maint' material.
Could you split this into two patches, one for 'maint' to describe the
output format, and another for 'next' (or 'dp/checkattr') to update the
SYNOPSIS part?
next prev parent reply other threads:[~2008-10-14 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 17:57 [PATCH] Improve and fix git-check-attr(1) Jonas Fonseca
2008-10-14 23:58 ` Junio C Hamano [this message]
2008-10-15 7:10 ` [PATCH 1/2] git-check-attr(1): add output and example sections Jonas Fonseca
2008-10-15 7:11 ` [PATCH 2/2] git-check-attr(1): use 'verse' for multi-line synopsis sections Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabd6686n.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=fonseca@diku.dk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.