All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: しらいしななこ <nanako3@bluebottle.com>, git@vger.kernel.org
Subject: Re: [BUG?] "git rebase --interactive" forces me to edit message.
Date: Fri, 06 Jun 2008 23:53:20 -0700	[thread overview]
Message-ID: <7vabhxpwgv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.DEB.1.00.0806070556030.1783@racer

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> But I started wondering (especially after read Junio's example) if you 
>> might have to stop and force edit the message even for commits you 
>> "pick", once you have a conflict.  The patch might not conflict, but 
>> with your logic shouldn't you be given a chance to amend messages, now 
>> it was discovered that the upstream did change that overlaps what you 
>> did?
>
> You do.  With a conflict, it stops.  If you do not commit, but only 
> resolve the conflicts and add them to the index, then continue the rebase 
> -i, it will ask you to commit.  Interactively.  (IOW an editor is fired 
> up.)

I might be misreading it, but my understanding of the scenario is:

 - you have pick A, pick B and pick C;
 - you reordered them to pick C, pick B and pick A;
 - the first one, pick C failed, and "add -u && rebase --continue" does
   ask for that pick C.

However, if neither pick B and pick A after that step has textual
conflicts, the command does not stop for them, and does not give you a
chance to adjust their potentially stale commit log messages.

I've already stated my position on this issue earlier in the thread.

      reply	other threads:[~2008-06-07  6:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05  3:58 [BUG?] "git rebase --interactive" forces me to edit message しらいしななこ
2008-06-05  4:14 ` Junio C Hamano
2008-06-05  4:40   ` Johannes Schindelin
2008-06-05  4:38 ` Johannes Schindelin
2008-06-06 21:46   ` しらいしななこ
2008-06-06 23:21     ` Junio C Hamano
     [not found] ` <200806062147.m56LlCOe030269@mi0.bluebottle.com>
2008-06-07  4:57   ` Johannes Schindelin
2008-06-07  6:53     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabhxpwgv.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=nanako3@bluebottle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.