All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ping Yin <pkufranky@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v5 2/5] git-submodule summary: show commit summary
Date: Tue, 11 Mar 2008 21:12:07 -0700	[thread overview]
Message-ID: <7vabl48tt4.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1205243539-797-3-git-send-email-pkufranky@gmail.com

I've squashed a moral equivalent of the following into this patch (I also
re-indented "case...esac").  Will perhaps queue in 'next' and after that
we can incrementally improve on it.

Thanks.

 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-submodule.sh b/git-submodule.sh
index a0ea913..ea23b45 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -400,7 +400,7 @@ cmd_summary() {
 				160000)
 				sha1_dst=$(GIT_DIR="$name/.git" git rev-parse HEAD)
 				;;
-				100644)
+				100644 | 100755 | 120000)
 				sha1_dst=$(git hash-object $name)
 				;;
 			esac

  parent reply	other threads:[~2008-03-12  4:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11 13:52 [PATCH v5 0/5] git-submodule summary Ping Yin
2008-03-11 13:52 ` [PATCH v5 1/5] git-submodule summary: code framework Ping Yin
2008-03-11 13:52   ` [PATCH v5 2/5] git-submodule summary: show commit summary Ping Yin
2008-03-11 13:52     ` [PATCH v5 3/5] git-submodule summary: limit summary size Ping Yin
2008-03-11 13:52       ` [PATCH v5 4/5] git-submodule summary: documentation Ping Yin
2008-03-11 13:52         ` [PATCH v5 5/5] git-submodule summary: test Ping Yin
2008-03-12  2:08     ` [PATCH v5 2/5] git-submodule summary: show commit summary Ping Yin
2008-03-12  2:12       ` Junio C Hamano
2008-03-12  2:30         ` Ping Yin
2008-03-12  4:12     ` Junio C Hamano [this message]
2008-03-12  4:28       ` Ping Yin
2008-03-12  6:15         ` Junio C Hamano
2008-03-12  8:27           ` Ping Yin
2008-03-12  8:30     ` [PATCH] git-submodule summary: fix that some "wc" flavors produce leading spaces Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabl48tt4.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pkufranky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.