From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
Andreas Ericsson <ae@op5.se>,
Git Mailing List <git@vger.kernel.org>,
Nicolas Pitre <nico@cam.org>
Subject: Re: [PATCH] pack-objects: Print a message describing the number of threads for packing
Date: Tue, 26 Feb 2008 01:19:14 -0800 [thread overview]
Message-ID: <7vablo848d.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20080226080634.GA4129@coredump.intra.peff.net
Jeff King <peff@peff.net> writes:
> On Tue, Feb 26, 2008 at 12:00:05AM -0800, Junio C Hamano wrote:
>
>> >> + if (progress)
>> >> + fprintf(stderr, "Using %d pack threads.\n",
>> >> + delta_search_threads);
>> >
>> > I just noticed that this was in next.
>>
>> Please send in a fix-up patch to remove it. I noticed it while
>> reviewing the patch, and even commented on it, but I somehow
>> forgot that this leftover debugging message disqualified the
>> series from 'next' when I was merging topics to 'next'.
>
> Are you sure you are thinking of the same message?
Ah, no.
But now you mention it, I tend to agree with you. This is
primarily of interest for git developers and I do not think the
end users would care. Maybe under --verbose or --debug option
(but I do not think we have --debug option anywhere).
next prev parent reply other threads:[~2008-02-26 9:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 8:20 [PATCH] pack-objects: Add runtime detection of online CPU's Andreas Ericsson
2008-02-12 8:27 ` Shawn O. Pearce
2008-02-12 8:49 ` Johannes Sixt
2008-02-12 11:18 ` Bert Wesarg
2008-02-12 12:21 ` Andreas Ericsson
2008-02-12 14:52 ` Michael Hendricks
2008-02-12 15:44 ` Brandon Casey
2008-02-23 2:11 ` Brandon Casey
2008-02-23 8:18 ` Andreas Ericsson
[not found] ` <1203732369-30314-1-git-send-email-casey@nrlssc.navy.mil>
2008-02-23 2:12 ` [PATCH] pack-objects: Print a message describing the number of threads for packing Brandon Casey
2008-02-26 7:49 ` Jeff King
2008-02-26 8:00 ` Junio C Hamano
2008-02-26 8:06 ` Jeff King
2008-02-26 9:19 ` Junio C Hamano [this message]
2008-02-26 9:33 ` Jeff King
2008-02-26 9:40 ` Andreas Ericsson
2008-02-26 15:53 ` Brandon Casey
2008-02-26 17:05 ` Nicolas Pitre
2008-02-26 21:25 ` Jeff King
2008-02-26 21:21 ` Jeff King
2008-02-26 22:50 ` Brandon Casey
2008-02-26 23:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vablo848d.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=ae@op5.se \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.