All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Johannes Sixt <j.sixt@viscovery.net>, git@vger.kernel.org
Subject: Re: [PATCH] Include rev-list options in git-log manpage.
Date: Fri, 18 Jan 2008 11:50:52 -0800	[thread overview]
Message-ID: <7vabn2ewv7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080118171827.GV29972@genesis.frugalware.org> (Miklos Vajna's message of "Fri, 18 Jan 2008 18:18:27 +0100")

Miklos Vajna <vmiklos@frugalware.org> writes:

> +ifndef::git-log[]
>  Using these options, linkgit:git-rev-list[1] will act similar to the
>  more specialized family of commit log tools: linkgit:git-log[1],
>  linkgit:git-show[1], and linkgit:git-whatchanged[1]
> +endif::git-log[]

> +ifndef::git-log[]
>  --bisect::
>  
>  Limit output to the one commit object which is roughly halfway between
> @@ -388,6 +302,7 @@ may not compile for example).
>  This option can be used along with `--bisect-vars`, in this case,
>  after all the sorted commit objects, there will be the same text as if
>  `--bisect-vars` had been used alone.
> +endif::git-log[]

I do not like these.  What you are really trying to express is
"this section makes sense only in rev-list documentation", not
"the current set of documentation this section does not make
sese is git-log".  We might end up including this in some other
documents.

IOW, they should rather be "ifdef::git-rev-list[]" instead.

  reply	other threads:[~2008-01-18 19:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 21:44 [PATCH] Include rev-list options in git-log manpage Miklos Vajna
2008-01-18  7:21 ` Junio C Hamano
2008-01-18 16:17   ` Miklos Vajna
2008-01-18 16:37     ` Johannes Sixt
2008-01-18 17:18       ` Miklos Vajna
2008-01-18 19:50         ` Junio C Hamano [this message]
2008-01-18 19:51         ` Junio C Hamano
2008-01-18 22:50           ` Miklos Vajna
2008-01-18 22:58             ` Miklos Vajna
2008-01-18 23:12               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabn2ewv7.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.