All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Steffen Prohaska <prohaska@zib.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/8] push: change push to fail if short ref name does not exist
Date: Sun, 28 Oct 2007 00:28:53 -0700	[thread overview]
Message-ID: <7vabq3wvd6.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 11935038081211-git-send-email-prohaska@zib.de

Steffen Prohaska <prohaska@zib.de> writes:

> You can use a branch's shortname to push it. Push used to create
> the branch on the remote side if it did not yet exist. If you
> specified the wrong branch accidentally it was created. A safety
> valve that pushes only existing branches may help to avoid
> errors.

I do not agree with this change.

If you misspelled the branch name (by the way, it is not a
"shortname", but what follows refs/heads/ is _the_ name of the
branch) "frotz" as "frtoz", and if a branch with the misspelled
name did _not_ exist locally, it would fail, with or without
this change, which is a good thing.

But if you named "nitfol" that exists locally when you meant to
push "frotz" out, if "nitfol" remotely existed, we will push
that anyway by mistake, even with this change.  It will prevent
the push only when "nitfol" did not happen to exist at the
remote side.

Earlier there was a discussion to introduce an optional
configuration that makes "git push" without any parameter to
push only the current branch out, in order to help people who
work with shared remote central repository.  That might be a
better alternative to avoid pushing out wrong branch by
mistake.  That approach would also make your 8/8 unnecessary.

  parent reply	other threads:[~2007-10-28  7:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-27 16:49 [PATCH 0/8 v2] improve push's refspec handling Steffen Prohaska
2007-10-27 16:50 ` [PATCH 1/8] push: change push to fail if short ref name does not exist Steffen Prohaska
2007-10-27 16:50   ` [PATCH 2/8] push: teach push new flag --create Steffen Prohaska
2007-10-27 16:50     ` [PATCH 3/8] add get_sha1_with_real_ref() returning full name of ref on demand Steffen Prohaska
2007-10-27 16:50       ` [PATCH 4/8] rev-parse: teach "git rev-parse --symbolic" to print the full ref name Steffen Prohaska
2007-10-27 16:50         ` [PATCH 5/8] push, send-pack: support pushing HEAD to real " Steffen Prohaska
2007-10-27 16:50           ` [PATCH 6/8] add ref_cmp_full_short() comparing full ref name with a short name Steffen Prohaska
2007-10-27 16:50             ` [PATCH 7/8] push: use same rules as git-rev-parse to resolve refspecs Steffen Prohaska
2007-10-27 16:50               ` [PATCH 8/8] push: teach push to be quiet if local ref is strict subset of remote ref Steffen Prohaska
2007-10-28  7:28                 ` Junio C Hamano
2007-10-28  8:20                   ` Steffen Prohaska
2007-10-28  7:28               ` [PATCH 7/8] push: use same rules as git-rev-parse to resolve refspecs Junio C Hamano
2007-10-27 22:16             ` [PATCH 6/8] add ref_cmp_full_short() comparing full ref name with a short name Daniel Barkalow
2007-10-28  7:28             ` Junio C Hamano
2007-10-27 22:03           ` [PATCH 5/8] push, send-pack: support pushing HEAD to real ref name Daniel Barkalow
2007-10-28  7:28           ` Junio C Hamano
2007-10-28  8:03             ` Steffen Prohaska
2007-10-28 15:10             ` Steffen Prohaska
2007-10-28 15:40               ` Junio C Hamano
2007-10-28 15:59                 ` Steffen Prohaska
2007-10-28 16:03                 ` Junio C Hamano
2007-10-28 16:30                   ` Steffen Prohaska
2007-10-28 20:58                     ` Junio C Hamano
2007-10-31 15:08                       ` Steffen Prohaska
2007-10-27 21:53         ` [PATCH 4/8] rev-parse: teach "git rev-parse --symbolic" to print the full " Daniel Barkalow
2007-10-28 13:49           ` Steffen Prohaska
2007-10-28  7:28         ` Junio C Hamano
2007-10-28  7:58           ` Steffen Prohaska
2007-10-28  8:06             ` Shawn O. Pearce
2007-10-28  8:56               ` Steffen Prohaska
2007-10-28 15:10                 ` Brian Gernhardt
2007-10-28  8:24             ` Junio C Hamano
2007-10-28  7:28       ` [PATCH 3/8] add get_sha1_with_real_ref() returning full name of ref on demand Junio C Hamano
2007-10-27 21:42   ` [PATCH 1/8] push: change push to fail if short ref name does not exist Daniel Barkalow
2007-10-28  7:28   ` Junio C Hamano [this message]
2007-10-28  8:43     ` Steffen Prohaska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabq3wvd6.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=prohaska@zib.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.