From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Fix file name quoting in simplified out patch detection for --cc output
Date: Sun, 02 Sep 2007 17:22:02 -0700 [thread overview]
Message-ID: <7vabs4oaxh.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200709022222.13865.jnareb@gmail.com> (Jakub Narebski's message of "Sun, 2 Sep 2007 22:22:13 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 8c1e02c..5d424e5 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3140,8 +3140,8 @@ sub git_patchset_body {
> # compact combined diff output can have some patches skipped
> # find which patch (using pathname of result) we are at now
> my $to_name;
> - if ($patch_line =~ m!^diff --cc "?(.*)"?$!) {
> - $to_name = $1;
> + if ($patch_line =~ m!^diff --cc ("?.*"?)$!) {
> + $to_name = unquote($1);
> }
This patch obviously makes sense, but I wonder why you use the
form m!foobar! here, instead of far simpler to read /foobar/
form?
next prev parent reply other threads:[~2007-09-03 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-02 20:22 [PATCH] gitweb: Fix file name quoting in simplified out patch detection for --cc output Jakub Narebski
2007-09-03 0:22 ` Junio C Hamano [this message]
2007-09-03 9:52 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabs4oaxh.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.