All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-fsck: add --lost-found option
Date: Mon, 02 Jul 2007 16:11:28 -0700	[thread overview]
Message-ID: <7vabuewgdb.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: Pine.LNX.4.64.0707021751380.4071@racer.site

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> With this option, dangling objects are not only reported, but also
> written to .git/lost-found/commit/ or .git/lost-found/other/.
>
> This obsoletes git-lost-found.

I haven't had chance to look at the code yet; this is only about
the design.

I think adding --lost-found to fsck is a wonderful idea.  I also
think deprecating lost-found and removing it in the longer term
is a good idea.

Please do not do that in a single patch.  This patch is at least
talking about three timeframes.

 1. git-fsck learns --lost-found
    The patch adds that to the code and the documentation.
    Then it is commented on, perhaps updated, and matures.

 2. git-lost-found is marked as "deprecated"
    This patch adds "deprecated" warning to the documentation.

 3. git-lost-found is removed.

  reply	other threads:[~2007-07-02 23:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-02 16:53 [PATCH] git-fsck: add --lost-found option Johannes Schindelin
2007-07-02 23:11 ` Junio C Hamano [this message]
2007-07-02 23:26   ` Johannes Schindelin
2007-07-03  0:08     ` Junio C Hamano
2007-07-03  0:33       ` Johannes Schindelin
2007-07-04  1:33         ` [PATCH] fsck --lost-found writes to subdirectories in .git/lost-found/ Jonas Fonseca
2007-07-04  1:41           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabuewgdb.fsf@assigned-by-dhcp.cox.net \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.