From: Junio C Hamano <junkio@cox.net>
To: Shawn Pearce <spearce@spearce.org>
Cc: git@vger.kernel.org
Cc: James Bowes <jbowes@dangerouslyinc.com>
Subject: Re: [PATCH] rev-parse: Identify short sha1 sums correctly.
Date: Tue, 29 May 2007 16:40:37 -0700 [thread overview]
Message-ID: <7vabvn5hca.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <1180478596243-git-send-email-jbowes@dangerouslyinc.com> (James Bowes's message of "Tue, 29 May 2007 18:43:16 -0400")
James Bowes <jbowes@dangerouslyinc.com> writes:
> find_short_packed_object was not loading the pack index files.
> Teach it to do so.
>
> Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>
I think this is the proper fix of the problem I was unhappy
about with 'next', rather than reverting the lazy index
loading. But I wonder how many _other_ places like this there
are that we might be missing...
Shawn, an Ack, and any ideas for futureproofing?
> sha1_name.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/sha1_name.c b/sha1_name.c
> index 8dfceb2..7df01af 100644
> --- a/sha1_name.c
> +++ b/sha1_name.c
> @@ -76,8 +76,11 @@ static int find_short_packed_object(int len, const unsigned char *match, unsigne
>
> prepare_packed_git();
> for (p = packed_git; p && found < 2; p = p->next) {
> - uint32_t num = p->num_objects;
> - uint32_t first = 0, last = num;
> + uint32_t num, last;
> + uint32_t first = 0;
> + open_pack_index(p);
> + num = p->num_objects;
> + last = num;
> while (first < last) {
> uint32_t mid = (first + last) / 2;
> const unsigned char *now;
> --
> 1.5.2.869.g6b3ba
next parent reply other threads:[~2007-05-29 23:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1180478596243-git-send-email-jbowes@dangerouslyinc.com>
2007-05-29 23:40 ` Junio C Hamano [this message]
2007-05-30 1:58 ` [PATCH] rev-parse: Identify short sha1 sums correctly Shawn O. Pearce
2007-05-30 2:02 ` Shawn O. Pearce
2007-05-29 23:29 James Bowes
2007-05-30 0:53 ` Junio C Hamano
2007-05-30 1:09 ` James Bowes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabvn5hca.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.