All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: bonzini@gnu.org
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH, nitpickingly final version] git-branch, git-checkout: autosetup for remote branch tracking
Date: Thu, 08 Mar 2007 02:22:37 -0800	[thread overview]
Message-ID: <7vabyo9gr6.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <45EFDE4B.3010408@lu.unisi.ch> (Paolo Bonzini's message of "Thu, 08 Mar 2007 10:58:35 +0100")

Paolo Bonzini <paolo.bonzini@lu.unisi.ch> writes:

> 	This fixes all the nits you pointed out. :-D
> 	Now, this was an experience to make...

Thanks.

Will apply after reviewing once more tomorrow, with fix-ups
locally if needed.  No need to resend.

> +
> +	colon = strchr(value, ':');
> +        if (!colon)

s/^\040{8}/\011/;

> diff --git a/trace.c b/trace.c
> index 27fef86..27b2e85 100644
> --- a/trace.c
> +++ b/trace.c
> @@ -41,13 +41,15 @@ static in...
> +int nfasprintf(char **str, const char *fmt, ...)
>  {
> +	int rc;
> +	va_list args;
> +
> +	va_start(args, fmt);
> +	rc = nfvasprintf(str, fmt, args);
> +	va_end(args);
> +	return args;
>  }

s/return args/return rc/;

  reply	other threads:[~2007-03-08 10:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-08  6:49 [PATCH, final version] git-branch, git-checkout: autosetup for remote branch tracking Paolo Bonzini
2007-03-08  9:47 ` Junio C Hamano
2007-03-08  9:58   ` [PATCH, nitpickingly " Paolo Bonzini
2007-03-08 10:22     ` Junio C Hamano [this message]
2007-03-08 21:59       ` Junio C Hamano
2007-03-08 22:10         ` [PATCH] git-branch: rename nor delete should not work when HEAD is detached Junio C Hamano
2007-03-10  0:59         ` [PATCH, nitpickingly final version] git-branch, git-checkout: autosetup for remote branch tracking Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabyo9gr6.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bonzini@gnu.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.