From: Junio C Hamano <junkio@cox.net>
To: Frank Sorenson <frank@tuxrocks.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-rev-list: Don't die on a bad tag
Date: Sat, 27 Aug 2005 02:14:57 -0700 [thread overview]
Message-ID: <7vacj3vizy.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <4310217D.80408@tuxrocks.com> (Frank Sorenson's message of "Sat, 27 Aug 2005 02:17:01 -0600")
Frank Sorenson <frank@tuxrocks.com> writes:
> The current cogito tree contains an invalid tag
> (junio-gpg-pub => 0918385dbd9656cab0d1d81ba7453d49bbc16250), and
> git-repack-script (and probably others) will die when git-rev-list
> tries to dump the objects. This patch changes it to complain, but
> continue.
>
> Signed-off-by: Frank Sorenson <frank@tuxrocks.com>
I think this patch is wrong.
The check you are disabling is to see if the repository contains
an object that a tag refers to, and the user wanted to slurp the
tag, along with whatever thing it refers to, so barfing and
dying is the only right thing to do.
The repository does not have the object the tag points at. IOW,
the repository is not fsck clean.
If it bothers you either you could drop that tag from cogito
repository (because there would not be anything that is signed
by _my_ public key anyway), or borrow the object from git.git
repository.
prev parent reply other threads:[~2005-08-27 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-27 8:17 [PATCH] git-rev-list: Don't die on a bad tag Frank Sorenson
2005-08-27 9:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vacj3vizy.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=frank@tuxrocks.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.