From: Junio C Hamano <gitster@pobox.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
"manlio.perillo\@gmail.com" <manlio.perillo@gmail.com>
Subject: Re: [PATCH] Handle path completion and colon for tcsh script
Date: Sat, 02 Feb 2013 12:10:00 -0800 [thread overview]
Message-ID: <7vboc2bhpj.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <E59706EF8DB1D147B15BECA3322E4BDC09AA38@eusaamb103.ericsson.se> (Marc Khouzam's message of "Sat, 2 Feb 2013 19:43:25 +0000")
Marc Khouzam <marc.khouzam@ericsson.com> writes:
> Recent enhancements to git-completion.bash provide
> intelligent path completion for git commands. Such
> completions do not add the '/' at the end of directories
> for recent versions of bash.
> ...
> Here is the update for tcsh completion which is needed to handle
> the cool new path completion feature just pushed to 'next'.
>
> Also, Manlio reported that tcsh completion was broken when using
> the colon, and this patch fixes the issue.
>
> I haven't quite figured out the process to indicate which branch
> a patch is meant for. Do I just mention it in the email?
Yes, instead of wondering "Do I mention it here?", saying "This
should come on top of Manlio's completion update." is good.
But I have to wonder if this is sweeping a problem under the rug.
Shouldn't the completion for bash users end completed directory name
with '/', even if we didn't have to worry about tcsh?
next prev parent reply other threads:[~2013-02-02 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 19:43 [PATCH] Handle path completion and colon for tcsh script Marc Khouzam
2013-02-02 20:10 ` Junio C Hamano [this message]
2013-02-03 19:59 ` Manlio Perillo
2013-02-03 20:43 ` Junio C Hamano
2013-02-04 2:50 ` Marc Khouzam
2013-02-04 3:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vboc2bhpj.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=manlio.perillo@gmail.com \
--cc=marc.khouzam@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.