From: Junio C Hamano <gitster@pobox.com>
To: John Keeping <john@keeping.me.uk>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
git@vger.kernel.org, "Eric S. Raymond" <esr@thyrsus.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [RFC/PATCH 2/8 v2] git_remote_helpers: fix input when running under Python 3
Date: Tue, 15 Jan 2013 12:51:13 -0800 [thread overview]
Message-ID: <7vbocq2mri.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130115194809.GU4574@serenity.lan> (John Keeping's message of "Tue, 15 Jan 2013 19:48:09 +0000")
John Keeping <john@keeping.me.uk> writes:
> Although 2to3 will fix most issues in Python 2 code to make it run under
> Python 3, it does not handle the new strict separation between byte
> strings and unicode strings. There is one instance in
> git_remote_helpers where we are caught by this, which is when reading
> refs from "git for-each-ref".
>
> While we could fix this by explicitly handling refs as byte strings,
> this is merely punting the problem to users of the library since the
> same problem will be encountered as soon you want to display the ref
> name to a user.
>
> Instead of doing this, explicit decode the incoming byte string into a
> unicode string.
That really feels wrong. Displaying is a separate issue and it is
the _right_ thing to punt the problem at the lower-level machinery
level.
> Following the lead of pygit2 (the Python bindings for
> libgit2 - see [1] and [2]),...
I do not think other people getting it wrong is not an excuse to
repeat the same mistake.
Is it really so cumbersome to handle byte strings as byte strings in
Python?
next prev parent reply other threads:[~2013-01-15 20:51 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 19:23 [PATCH 0/8] Initial support for Python 3 John Keeping
2013-01-12 19:23 ` [PATCH 1/8] git_remote_helpers: Allow building with " John Keeping
2013-01-12 19:23 ` [PATCH 2/8] git_remote_helpers: fix input when running under " John Keeping
2013-01-13 3:26 ` Michael Haggerty
2013-01-13 16:17 ` John Keeping
2013-01-14 4:48 ` Michael Haggerty
2013-01-14 9:47 ` John Keeping
2013-01-15 19:48 ` [RFC/PATCH 2/8 v2] " John Keeping
2013-01-15 20:51 ` Junio C Hamano [this message]
2013-01-15 21:54 ` John Keeping
2013-01-15 22:04 ` Junio C Hamano
2013-01-15 22:40 ` [RFC/PATCH 2/8 v3] " John Keeping
2013-01-16 0:03 ` Pete Wyckoff
2013-01-16 9:45 ` John Keeping
2013-01-17 0:29 ` Pete Wyckoff
2013-01-12 19:23 ` [PATCH 3/8] git_remote_helpers: Force rebuild if python version changes John Keeping
2013-01-12 23:30 ` Pete Wyckoff
2013-01-13 16:26 ` John Keeping
2013-01-13 17:14 ` Pete Wyckoff
2013-01-13 17:52 ` John Keeping
2013-01-15 22:58 ` John Keeping
2013-01-17 0:27 ` Pete Wyckoff
2013-01-12 19:23 ` [PATCH 4/8] git_remote_helpers: Use 2to3 if building with Python 3 John Keeping
2013-01-12 19:23 ` [PATCH 5/8] svn-fe: allow svnrdump_sim.py to run " John Keeping
2013-01-12 19:23 ` [PATCH 6/8] git-remote-testpy: hash bytes explicitly John Keeping
2013-01-12 19:23 ` [PATCH 7/8] git-remote-testpy: don't do unbuffered text I/O John Keeping
2013-01-12 19:23 ` [PATCH 8/8] git-remote-testpy: call print as a function John Keeping
2013-01-12 23:43 ` [PATCH 0/8] Initial support for Python 3 Pete Wyckoff
2013-01-13 0:41 ` John Keeping
2013-01-13 12:34 ` John Keeping
2013-01-13 16:40 ` Pete Wyckoff
2013-01-13 17:35 ` John Keeping
2013-01-17 18:53 ` [PATCH v2 0/8] Initial Python 3 support John Keeping
2013-01-17 18:53 ` [PATCH v2 1/8] git_remote_helpers: allow building with Python 3 John Keeping
2013-01-17 18:53 ` [PATCH v2 2/8] git_remote_helpers: fix input when running under " John Keeping
2013-01-17 18:53 ` [PATCH v2 3/8] git_remote_helpers: force rebuild if python version changes John Keeping
2013-01-17 18:53 ` [PATCH v2 4/8] git_remote_helpers: use 2to3 if building with Python 3 John Keeping
2013-01-18 5:15 ` Sverre Rabbelier
2013-01-18 10:32 ` John Keeping
2013-01-19 7:52 ` Sverre Rabbelier
2013-01-17 18:53 ` [PATCH v2 5/8] svn-fe: allow svnrdump_sim.py to run " John Keeping
2013-01-17 18:53 ` [PATCH v2 6/8] git-remote-testpy: hash bytes explicitly John Keeping
2013-01-17 20:36 ` Junio C Hamano
2013-01-17 20:43 ` Junio C Hamano
2013-01-17 21:00 ` John Keeping
2013-01-17 21:05 ` John Keeping
2013-01-17 22:24 ` Junio C Hamano
2013-01-17 22:30 ` John Keeping
2013-01-17 22:57 ` Junio C Hamano
2013-01-17 18:54 ` [PATCH v2 7/8] git-remote-testpy: don't do unbuffered text I/O John Keeping
2013-01-18 3:50 ` Sverre Rabbelier
2013-01-17 18:54 ` [PATCH v2 8/8] git-remote-testpy: call print as a function John Keeping
2013-01-18 3:48 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbocq2mri.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=esr@thyrsus.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=mhagger@alum.mit.edu \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.