All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Oded Shimon <ods15@ods15.dyndns.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add --src/dst-prefix to git-formt-patch in git-rebase.sh
Date: Thu, 09 Sep 2010 11:35:19 -0700	[thread overview]
Message-ID: <7vbp86n4t4.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1284019625-14096-1-git-send-email-ods15@ods15.dyndns.org> (Oded Shimon's message of "Thu\,  9 Sep 2010 11\:07\:05 +0300")

Oded Shimon <ods15@ods15.dyndns.org> writes:

> For the case of "diff.noprefix" in git-config, git-format-patch should
> still output diff with standard prefixes for git-am
>
> Signed-off-by: Oded Shimon <ods15@ods15.dyndns.org>

Hmm.

> diff --git a/git-rebase.sh b/git-rebase.sh
> index 7508463..e83a0cf 100755
> --- a/git-rebase.sh
> +++ b/git-rebase.sh
> @@ -565,7 +565,7 @@ fi
>  
>  if test -z "$do_merge"
>  then
> -	git format-patch -k --stdout --full-index --ignore-if-in-upstream \
> +	git format-patch -k --stdout --full-index --ignore-if-in-upstream --src-prefix=a/ --dst-prefix=b/ \
>  		--no-renames $root_flag "$revisions" |
>  	git am $git_am_opt --rebasing --resolvemsg="$RESOLVEMSG" &&

As the format-patch invocation is already multi-line, you probably would
want to use a continuation line with "\" to keep the line length shorter.

We need to protect ourselves from crazy people, so regrettably something
like this patch is unavoidable, albeit unsightly.

Thanks.

  parent reply	other threads:[~2010-09-09 18:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 13:54 [PATCH] Add explicit --src/dst-prefix to git-formt-patch in git-rebase.sh for the case of "diff.noprefix" in git-config Oded Shimon
2010-09-08 20:31 ` ods15
2010-09-08 21:07 ` Jan Krüger
2010-09-09  8:07 ` [PATCH] Add --src/dst-prefix to git-formt-patch in git-rebase.sh Oded Shimon
2010-09-09  8:36   ` [Alt. PATCH] format-patch: do not use diff UI config Thomas Rast
2010-09-09 19:13     ` Sverre Rabbelier
2010-09-09 19:43     ` Jeff King
2010-09-10 16:21     ` Junio C Hamano
2010-09-09 18:35   ` Junio C Hamano [this message]
2010-09-09 18:49     ` [PATCH] Add --src/dst-prefix to git-formt-patch in git-rebase.sh ods15
2010-09-09 18:49     ` Oded Shimon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbp86n4t4.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ods15@ods15.dyndns.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.