From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] gitweb: Create install target for gitweb in Makefile
Date: Sat, 01 May 2010 12:45:42 -0700 [thread overview]
Message-ID: <7vbpcz4d95.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100429235046.29606.35311.stgit@localhost.localdomain> (Jakub Narebski's message of "Fri\, 30 Apr 2010 01\:58\:22 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> Installing gitweb is now as easy as
> # make gitwebdir=/var/www/cgi-bin gitweb-install ;# as root
> The gitweb/INSTALL file was updated accordingly.
Just a style, but I prefer a blank line on both sides of an example
command line like this.
> There is a question whether to rely on correctly set file permissions
> during build phase, i.e.
>
> $(INSTALL) $(GITWEB_FILES) '$(DESTDIR_SQ)$(gitwebdir_SQ)'
>
> or whether to ensure correct file permissions during installl phase
>
> $(INSTALL) -m 755 $(GITWEB_PROGRAMS) '$(DESTDIR_SQ)$(gitwebdir_SQ)'
> $(INSTALL) -m 644 $(GITWEB_FILES) '$(DESTDIR_SQ)$(gitwebdir_SQ)'
>
> Currently the first option is used.
Hmm, the reason being? I do not have a strong preference either way, but
the primary Makefile seems to use "-m mode".
> Note that install-* targets, including new install-gitweb, are not
> marked as .PHONY
The reason being?
My preference for the standard targets like "all", "clean", and "install"
is to make them double-colon rules and mark them as phoneys.
next prev parent reply other threads:[~2010-05-01 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 23:58 [PATCH/RFC] gitweb: Create install target for gitweb in Makefile Jakub Narebski
2010-05-01 19:45 ` Junio C Hamano [this message]
2010-05-01 20:36 ` Jakub Narebski
2010-05-11 23:45 ` Petr Baudis
2010-05-11 23:49 ` J.H.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbpcz4d95.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.