From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Eric Wong <normalperson@yhbt.net>,
git@vger.kernel.org
Subject: Re: [RFC/PATCH] rebase: add -x option to record original commit name
Date: Fri, 05 Feb 2010 20:43:45 -0800 [thread overview]
Message-ID: <7vbpg3dldq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <76718491002052018s324747ecj31963b493868dbbd@mail.gmail.com> (Jay Soffian's message of "Fri\, 5 Feb 2010 23\:18\:45 -0500")
Jay Soffian <jaysoffian@gmail.com> writes:
> Since there is a difference of opinion here, how about this proposal:
>
> 1) We keep -x in cherry-pick
>
> 2) I convince you to add my -x patch to rebase.sh (hmm, how to do that?) :-)
>
> 3) We add a -X option to both cherry-pick and rebase.sh that records
> in the notes instead of in the log message.
How could that be a counterproposal to a deprecation of -x and adding
hooks as a replacement, as a solution to more general issues?
>> I ended up using this hacky script for that. It finds the svn uuid from
>> the metadata file, and then finds ".rev_map.$uuid" files from all over the
>> place to see if any of them contains a record that points at the git
>> commit I am interested in.
>>
>> I really wish "git svn" has a built-in way to do something like that;
>> perhaps I didn't look hard enough.
>
> Is git svn find-rev not what you want? (Caveat, it doesn't seem to
> work for me, but it's claimed description seems to be what you're
> asking for.)
Maybe, but it calls cmt_metadata() which is "grep ^git-svn-id:" of the
commit object, so we know why it doesn't X-<.
next prev parent reply other threads:[~2010-02-06 4:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 1:19 [RFC/PATCH] rebase: add -x option to record original commit name Jay Soffian
2010-02-06 1:35 ` Junio C Hamano
2010-02-06 1:58 ` Jay Soffian
2010-02-06 2:00 ` Jay Soffian
2010-02-06 2:57 ` Junio C Hamano
2010-02-06 4:18 ` Jay Soffian
2010-02-06 4:43 ` Junio C Hamano [this message]
2010-02-06 5:19 ` Jay Soffian
2010-02-06 13:32 ` tytso
2010-02-06 17:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbpg3dldq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.