From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] diff: allow turning on textconv explicitly for plumbing
Date: Sun, 07 Dec 2008 20:08:35 -0800 [thread overview]
Message-ID: <7vbpvn9um4.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vfxkz9v8f.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 07 Dec 2008 19:55:12 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Jeff King <peff@peff.net> writes:
>
>> I know this is not strictly a bugfix and we are in -rc, but:
>>
>> 1. It is an enhancement to a previously unreleased feature, and
>> shouldn't affect anything outside of that.
>>
>> 2. It affects the scripting interface to textconv, so I would like to
>> get it in before textconv is ever released so that it is always the
>> "right way" to turn text conversion off or on.
>
> I'd agree with #1, especially if you said "doesn't" instead of
> "shouldn't".
>
> But I am not 100% sure if the scripting part is "the right way".
But I'll apply them anyway.
next prev parent reply other threads:[~2008-12-08 4:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 2:57 [PATCH 2/3] diff: allow turning on textconv explicitly for plumbing Jeff King
2008-12-08 3:55 ` Junio C Hamano
2008-12-08 4:08 ` Junio C Hamano [this message]
2008-12-08 4:59 ` Jeff King
2008-12-08 6:52 ` Junio C Hamano
2008-12-08 7:14 ` Jeff King
2008-12-08 8:27 ` Junio C Hamano
2008-12-09 5:48 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbpvn9um4.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.