From: Junio C Hamano <gitster@pobox.com>
To: Robert Schiele <rschiele@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>, git@vger.kernel.org
Subject: Re: [PATCH] add definitions for global variables to shell.c
Date: Tue, 19 Aug 2008 16:09:42 -0700 [thread overview]
Message-ID: <7vbpzoy53d.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080819091830.GG11842@schiele.dyndns.org> (Robert Schiele's message of "Tue, 19 Aug 2008 11:18:30 +0200")
Robert Schiele <rschiele@gmail.com> writes:
> On Tue, Aug 19, 2008 at 10:49:53AM +0200, Johannes Sixt wrote:
>
>> Why not just revert 5b8e6f85f (shrink git-shell)? It was a nice try. If it
>> had not proved as a maintainance burden, it would have had merits. But who
>> these days cares whether git-shell takes 300K or 30K in the light of that
>> it goes out of the way anyway by execing some other process at the first
>> opportunity?
>
> Sounds reasonable to me. Doing this in a clean way would require more
> restructuring in the code. So far this change started a chain of changes
> where each change tried to solve one issue and caused a more severe one.
>
> Though it would not only be 5b8e6f85 to be reverted but also 78568448 that
> tried to fix up problems that 5b8e6f85 caused.
I have no issue with that. Some people also mumbled about auditability,
which I did not find particularly convincing.
next prev parent reply other threads:[~2008-08-19 23:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 12:37 [PATCH] add definitions for global variables to shell.c Robert Schiele
2008-08-19 0:29 ` Junio C Hamano
2008-08-19 7:26 ` Robert Schiele
2008-08-19 7:53 ` Junio C Hamano
2008-08-19 8:16 ` Robert Schiele
2008-08-19 8:49 ` Johannes Sixt
2008-08-19 9:18 ` Robert Schiele
2008-08-19 23:09 ` Junio C Hamano [this message]
2008-08-20 1:06 ` [PATCH 1/2] shell: do not play duplicated definition games to shrink the executable Junio C Hamano
2008-08-20 1:06 ` [PATCH 2/2] Build-in "git-shell" Junio C Hamano
2008-08-20 6:54 ` Johannes Sixt
2008-08-20 1:06 ` [PATCH] add definitions for global variables to shell.c Junio C Hamano
2008-08-20 4:36 ` Robert Schiele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbpzoy53d.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=rschiele@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.