All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Geoffrey Irving <irving@naml.us>, git@vger.kernel.org
Subject: Re: cherry picking changesets instead of commits
Date: Wed, 28 May 2008 16:56:49 -0700	[thread overview]
Message-ID: <7vbq2qrni6.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080528224819.GA15252@sigill.intra.peff.net> (Jeff King's message of "Wed, 28 May 2008 18:48:19 -0400")

Jeff King <peff@peff.net> writes:

> doc/git-gui: make gitk "see also" a link
>
> Even though git-gui and gitk are both maintained separately,
> the documentation is part of core git, and thus it makes
> sense to use the linkgit macro to create an href in the HTML
> documentation.
> ---
>  Documentation/git-gui.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/git-gui.txt b/Documentation/git-gui.txt
> index 6d6cd5d..cf2541f 100644
> --- a/Documentation/git-gui.txt
> +++ b/Documentation/git-gui.txt
> @@ -81,7 +81,7 @@ git gui browser maint::
>  
>  See Also
>  --------
> -'gitk(1)'::
> +linkgit:gitk[1]::
>  	The git repository browser.  Shows branches, commit history
>  	and file differences.  gitk is the utility started by
>  	git-gui's Repository Visualize actions.

Hmm.

First a bit offtopic to avoid duplicated work.  Please nobody waste your
time sending s/See Also/SEE ALSO/ clean-up patch.  I've done that already.

Now, I do not think it is customary to say anything but the name of the
manual page if you refer to one in SEE ALSO section.  I am wondering if we
would want to remove the three-liner for consistency (but haven't done so,
neither the short description of qgit and others in gitk manual page is
gone yet).

 Documentation/git-gui.txt |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/Documentation/git-gui.txt b/Documentation/git-gui.txt
index 6d6cd5d..cea8f8a 100644
--- a/Documentation/git-gui.txt
+++ b/Documentation/git-gui.txt
@@ -79,12 +79,9 @@ git gui browser maint::
 	selected in the browser can be viewed with the internal
 	blame viewer.
 
-See Also
+SEE ALSO
 --------
-'gitk(1)'::
-	The git repository browser.  Shows branches, commit history
-	and file differences.  gitk is the utility started by
-	git-gui's Repository Visualize actions.
+linkgit:gitk[1]
 
 Other
 -----

  reply	other threads:[~2008-05-28 23:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-28 18:06 cherry picking changesets instead of commits Geoffrey Irving
2008-05-28 18:19 ` Junio C Hamano
2008-05-28 18:28   ` Geoffrey Irving
2008-05-28 18:46     ` Junio C Hamano
2008-05-28 19:42       ` Geoffrey Irving
2008-05-28 20:46         ` Junio C Hamano
2008-05-28 21:14           ` Geoffrey Irving
2008-05-28 22:38             ` Jeff King
2008-05-28 22:48               ` Jeff King
2008-05-28 23:56                 ` Junio C Hamano [this message]
2008-05-29  0:12                   ` Jeff King
2008-05-29  0:04             ` [PATCH] Documentation: git-cherry uses git-patch-id Junio C Hamano
2008-05-29  0:07               ` Geoffrey Irving

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbq2qrni6.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=irving@naml.us \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.