From: Junio C Hamano <gitster@pobox.com>
To: Bruno Cesar Ribas <ribas@c3sl.ufpr.br>
Cc: Jakub Narebski <jnareb@gmail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list
Date: Thu, 07 Feb 2008 22:21:04 -0800 [thread overview]
Message-ID: <7vbq6sm0j3.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080208041542.GA28336@c3sl.ufpr.br> (Bruno Cesar Ribas's message of "Fri, 8 Feb 2008 02:15:42 -0200")
Bruno Cesar Ribas <ribas@c3sl.ufpr.br> writes:
> Just Remembering
>
> On Wed, Feb 06, 2008 at 11:37:51AM -0800, Jakub Narebski wrote:
>> Bruno Ribas <ribas@c3sl.ufpr.br> writes:
>><snip>
>> Good catch (although it wasn't actually a bug).
>
> Not a bug but makes the code cleaner =)
I think I saw very similar 's|projectroot/$path|$git_dir|' patch
recently. If there are more of the same, I'd rather see all of
them in a single patch.
next prev parent reply other threads:[~2008-02-08 6:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 17:15 [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list Bruno Ribas
2008-02-06 19:37 ` Jakub Narebski
2008-02-08 4:15 ` Bruno Cesar Ribas
2008-02-08 6:21 ` Junio C Hamano [this message]
2008-02-08 9:15 ` Jakub Narebski
2008-02-10 2:46 ` Bruno Cesar Ribas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbq6sm0j3.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=ribas@c3sl.ufpr.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.