All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
	git@vger.kernel.org, krh@redhat.com
Subject: Re: [PATCH 4/3] t3700: avoid racy git situation
Date: Thu, 08 Nov 2007 12:42:40 -0800	[thread overview]
Message-ID: <7vbqa431vj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0711081511440.4362@racer.site> (Johannes Schindelin's message of "Thu, 8 Nov 2007 15:16:17 +0000 (GMT)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> The problem is that the index has the same timestamp as the file "foo".
>
> Therefore, git cannot tell if "foo" is up-to-date in the index, since it 
> could have been modified (and indeed is) just a fraction of a second later 
> than the index was last updated.
>
> And since diff-index, as called from the test script, does not generate a 
> diff, but really only determines if the index information suggests that 
> the files are up-to-date, there is not really much you can do.
>
> This is our good old friend, the racy git problem.

That sounds very wrong.

What happened to the ce_smudge_racily_clean_entry() call that is
done from write_index()?

> NOTE: other scms do not have this problem, mostly because they are too 
> slow to trigger it.

I recall racy-hg mentioned on their development list twice, a
few months apart, and CVS has the "delay the return from a
commit to the next full second" or something to work around
problems in the timestamp recorded in CVS/Entries.

  parent reply	other threads:[~2007-11-08 20:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-08 12:14 [PATCH 0/3] builtin-commit fixes Johannes Schindelin
2007-11-08 12:15 ` [PATCH 1/3] builtin-commit: fix reflog message generation Johannes Schindelin
2007-11-08 12:15 ` [PATCH 2/3] launch_editor(): read the file, even when EDITOR=: Johannes Schindelin
2007-11-08 12:33   ` Johannes Sixt
2007-11-08 14:06     ` [PATCH REPLACING " Johannes Schindelin
2007-11-08 12:16 ` [PATCH 3/3] builtin-commit: fix author date with --amend --author=<author> Johannes Schindelin
2007-11-08 14:14 ` [PATCH 4/3] t3700: avoid racy git situation Johannes Schindelin
2007-11-08 14:34   ` Johannes Sixt
2007-11-08 15:16     ` Johannes Schindelin
2007-11-08 15:27       ` Kristian Høgsberg
2007-11-08 15:45       ` Johannes Sixt
2007-11-08 20:42       ` Junio C Hamano [this message]
2007-11-09  3:00         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbqa431vj.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=krh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.