All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Cc: git@vger.kernel.org, Robin Rosenberg <robin.rosenberg@dewire.com>
Subject: Re: [PATCH 2/2] Wire new date formats to --date=<format> parser.
Date: Fri, 13 Jul 2007 23:54:19 -0700	[thread overview]
Message-ID: <7vbqeflbl0.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070714064451.GH11809@lug-owl.de> (Jan-Benedict Glaw's message of "Sat, 14 Jul 2007 08:44:51 +0200")

Jan-Benedict Glaw <jbglaw@lug-owl.de> writes:

> On Fri, 2007-07-13 23:43:00 -0700, Junio C Hamano <gitster@pobox.com> wrote:
>> --- a/revision.c
>> +++ b/revision.c
>> @@ -1133,6 +1133,14 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
>>  			if (!strncmp(arg, "--date=", 7)) {
>>  				if (!strcmp(arg + 7, "relative"))
>>  					revs->date_mode = DATE_RELATIVE;
>> +				else if (!strcmp(arg + 7, "iso8601") ||
>> +					 !strcmp(arg + 7, "iso"))
>> +					revs->date_mode = DATE_ISO8601;
>> +				else if (!strcmp(arg + 7, "rfc2822") ||
>> +					 !strcmp(arg + 7, "rfc"))
>
> Maybe also add "rfc822"?

I've thought about it, but did not bother; I suspect people would
just say "rfc" anyway.

  reply	other threads:[~2007-07-14  6:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-13 20:22 [PATCH] Support output ISO 8601 format dates Robin Rosenberg
2007-07-13 22:11 ` Junio C Hamano
2007-07-13 23:00   ` Robin Rosenberg
2007-07-14  6:42     ` [PATCH 1/2] Make show_rfc2822_date() just another date output format Junio C Hamano
2007-07-14  6:43     ` [PATCH 2/2] Wire new date formats to --date=<format> parser Junio C Hamano
2007-07-14  6:44       ` Jan-Benedict Glaw
2007-07-14  6:54         ` Junio C Hamano [this message]
2007-07-14 10:29       ` Robin Rosenberg
2007-07-14  6:49     ` [PATCH] Document new --date=<format> Junio C Hamano
2007-07-15 21:23 ` [PATCH] Support output ISO 8601 format dates Jan Hudec
2007-07-15 22:14   ` Junio C Hamano
2007-07-15 23:19   ` Robin Rosenberg
2007-07-15 23:57     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbqeflbl0.fsf@assigned-by-dhcp.cox.net \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jbglaw@lug-owl.de \
    --cc=robin.rosenberg@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.