All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: "Git List" <git@vger.kernel.org>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Jonathan Nieder" <jrnieder@gmail.com>,
	"Stefano Lattarini" <stefano.lattarini@gmail.com>,
	"Martin von Zweigbergk" <martin.von.zweigbergk@gmail.com>
Subject: Re: [PATCH v6 4/7] Remove obsolete LONG_USAGE which breaks xgettext
Date: Wed, 25 Jul 2012 10:13:33 -0700	[thread overview]
Message-ID: <7vd33jdarm.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <6326c11afd7b4077f2aba27101fd9acc8e2f8b6a.1343227806.git.worldhello.net@gmail.com> (Jiang Xin's message of "Wed, 25 Jul 2012 22:53:10 +0800")

Jiang Xin <worldhello.net@gmail.com> writes:

> The obsolete LONG_USAGE variable has the following message in it:
>
>     A'\''--B'\''--C'\''
>
> And such complex LONG_USAGE message will break xgettext when
> extracting l10n messages. But if single quotes are removed from
> the message, xgettext works fine on 'git-rebase.sh'.
>
> Since there is a modern OPTIONS_SPEC variable in use in this
> script, it's safe to remove the obsolete USAGE and LONG_USAGE
> variables.
>
> Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
> Reviewed-by: Stefano Lattarini <stefano.lattarini@gmail.com>

I've retitled it and swapped the paragraphs around when queuing
this.  LONG_USAGE and USAGE are not just "obsolete" but completely
unused, so they should be removed, even if xgettext did not have a
bug to choke on their contents.

Thanks.

  reply	other threads:[~2012-07-25 17:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25 14:53 [PATCH v6 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-25 14:53 ` [PATCH v6 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-25 14:53 ` [PATCH v6 2/7] i18n: rebase: mark messages for translation Jiang Xin
2012-07-25 14:53 ` [PATCH v6 3/7] i18n: Rewrite gettext messages start with dash Jiang Xin
2012-07-25 14:53 ` [PATCH v6 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jiang Xin
2012-07-25 17:13   ` Junio C Hamano [this message]
2012-07-25 14:53 ` [PATCH v6 5/7] i18n: am: mark more strings for translation Jiang Xin
2012-07-25 17:18   ` Junio C Hamano
2012-07-25 14:53 ` [PATCH v6 6/7] Remove dead code which contains bad gettext block Jiang Xin
2012-07-25 14:53 ` [PATCH v6 7/7] i18n: merge-recursive: mark strings for translation Jiang Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd33jdarm.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=martin.von.zweigbergk@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=stefano.lattarini@gmail.com \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.