All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Peter Baumann <waste.manager@gmx.de>
Cc: Jeff King <peff@peff.net>, Adam Borowski <kilobyte@angband.pl>,
	git@vger.kernel.org
Subject: Re: git-bisect working only from toplevel dir
Date: Thu, 24 Nov 2011 03:50:22 -0800	[thread overview]
Message-ID: <7vd3chage9.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20111124070659.GC6291@m62s10.vlinux.de> (Peter Baumann's message of "Thu, 24 Nov 2011 08:06:59 +0100")

Peter Baumann <waste.manager@gmx.de> writes:

> On Wed, Nov 23, 2011 at 12:45:18PM -0800, Junio C Hamano wrote:
> ...
>> Also didn't we make bisect workable in a bare repository recently? So the
>> start-up sequence has to be something more elaborate like...
>> ...
>> and then inside bisect_next() you would check if $prefix exists, and go
>> there to run bisect--helper (or fail to go there and say "cannot test").
>
> But is the "cannot test" aka exit(127) the best we can do in this case?

Yeah, thinking about it a bit more, it may probably be better to make it a
failure. The user explicitly asked "be in _this_ directory and run make;
it should succeed for the bisection test to pass". If the bisection test
criterion the user was interested in was a successful build of the whole
project (not the subpart of the current directory), the user would have
gone up to the top-level and "bisect run make" there.

  reply	other threads:[~2011-11-24 11:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23 14:50 git-bisect working only from toplevel dir Adam Borowski
2011-11-23 19:09 ` Junio C Hamano
2011-11-23 19:23   ` Jeff King
2011-11-23 20:09     ` Adam Borowski
2011-11-23 21:45       ` Jeff King
2011-11-23 20:26     ` Peter Baumann
2011-11-23 21:36       ` Jeff King
2011-11-23 20:45     ` Junio C Hamano
2011-11-24  7:06       ` Peter Baumann
2011-11-24 11:50         ` Junio C Hamano [this message]
2011-11-29 12:06           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd3chage9.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kilobyte@angband.pl \
    --cc=peff@peff.net \
    --cc=waste.manager@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.