All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Michael Cox <mhcox@bluezoosoftware.com>, git@vger.kernel.org
Subject: Re: [PATCH] Makefile: Fix CDPATH problem
Date: Fri, 19 Mar 2010 16:43:28 -0700	[thread overview]
Message-ID: <7vd3yz513z.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100319234033.GA18035@progeny.tock> (Jonathan Nieder's message of "Fri\, 19 Mar 2010 18\:40\:34 -0500")

Jonathan Nieder <jrnieder@gmail.com> writes:

> CDPATH takes scripts to unexpected places.  For example, with a CDPATH
> including a blt directory:
>
>  make -C templates DESTDIR='' install
>  make[1]: Entering directory `/users/e477610/exptool/src/git-1.7.0.2/templates'
>  install -d -m 755 '/home/e477610/exptool/share/git-core/templates'
>  (cd blt && gtar cf - .) | \
> 	(cd '/home/e477610/exptool/share/git-core/templates' && umask 022 && gtar xof -)
>  gtar: This does not look like a tar archive
>
> The CDPATH mechanism does not implicitly add "." at the beginning of
> CDPATH, which is the most irritating part.
>
> Most git scripts already protect against use of CDPATH through
> git-sh-setup, but the Makefile doesn’t.

Eh, the rationale and the in-code comment need to be fixed.  The issue is
not "taking us to random places", but "reporting the name of the random
place in its standard output".

But other than that, this is something we have seen on the list a few
times, and I think it is about time to do this.

Thanks.

  reply	other threads:[~2010-03-19 23:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-19 21:36 Error building installing on Redhat Linux Server release 5.3 (Tikanga) Michael Cox
     [not found] ` <7veijgc6md.fsf@alter.siamese.dyndns.org>
2010-03-19 22:25   ` Michael Cox
2010-03-19 22:51     ` Michael Cox
2010-03-19 23:40     ` [PATCH] Makefile: Fix CDPATH problem Jonathan Nieder
2010-03-19 23:43       ` Junio C Hamano [this message]
2010-03-20  0:06         ` [PATCH v2] " Jonathan Nieder
2010-03-19 22:57 ` Error building installing on Redhat Linux Server release 5.3 (Tikanga) Jonathan Nieder
2010-03-19 22:59   ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd3yz513z.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=mhcox@bluezoosoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.