All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Remi Vanicat <vanicat@debian.org>
Cc: git@vger.kernel.org
Subject: Re: [BUG] git filter-branch failed to suppress a file with an accentuated letter in the filename
Date: Fri, 15 Feb 2008 09:50:11 -0800	[thread overview]
Message-ID: <7vd4qygld8.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <87bq6iw42w.dlv@maison.homelinux.org> (Remi Vanicat's message of "Fri, 15 Feb 2008 17:56:55 +0100")

Remi Vanicat <vanicat@debian.org> writes:

> The culprit seem to be those line of filter-branch: (around line 279) 
> 		git diff-index -r $commit | cut -f 2- | tr '\012' '\000' | \
> 			xargs -0 git update-index --add --replace --remove
> git diff-index giving the filename as "foo/bar\303\251"

I have to wonder in what century filter-branch was written ;-)

Shouldn't those two lines be:

	git diff-index -r --name-only $commit |
        git update-index --add --replace --remove --stdin

these days, without any of the cut and cruft?

  reply	other threads:[~2008-02-15 17:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15 16:56 [BUG] git filter-branch failed to suppress a file with an accentuated letter in the filename Remi Vanicat
2008-02-15 17:50 ` Junio C Hamano [this message]
2008-02-15 18:12   ` Johannes Schindelin
2008-02-15 22:21     ` Junio C Hamano
2008-02-16  3:09       ` Johannes Schindelin
2008-02-16 12:48         ` Johannes Schindelin
2008-02-16  6:34   ` Remi Vanicat
2008-02-16  7:54     ` Junio C Hamano
2008-02-16  8:26       ` Remi Vanicat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd4qygld8.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=vanicat@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.