From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Remove repo version check from setup_git_directory
Date: Sun, 09 Dec 2007 02:24:38 -0800 [thread overview]
Message-ID: <7vd4tgrwrd.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071209101439.GA18312@laptop> (Nguyễn Thái Ngọc Duy's message of "Sun, 9 Dec 2007 17:14:39 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> setup_git_directory_gently has done the check already.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> Sorry, somehow I left this line behind. It should have been gone
> from my re-fix patch.
>
> setup.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/setup.c b/setup.c
> index e96a316..b59dbe7 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -388,7 +388,6 @@ int check_repository_format(void)
> const char *setup_git_directory(void)
> {
> const char *retval = setup_git_directory_gently(NULL);
> - check_repository_format();
Ah, because the previous line already calls the same repository format
check, this is now unneeded, indeed.
Thanks.
prev parent reply other threads:[~2007-12-09 10:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 10:14 [PATCH] Remove repo version check from setup_git_directory Nguyễn Thái Ngọc Duy
2007-12-09 10:24 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4tgrwrd.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.