All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Sam Vilain <sam@vilain.net>
Cc: Sam Vilain <sam.vilain@catalyst.net.nz>, git@vger.kernel.org
Subject: Re: [PATCH] post-update hook: update working copy
Date: Fri, 02 Nov 2007 01:49:46 -0700	[thread overview]
Message-ID: <7vd4ut58wl.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <472A9B26.2020608@vilain.net> (Sam Vilain's message of "Fri, 02 Nov 2007 16:36:06 +1300")

Sam Vilain <sam@vilain.net> writes:

> changes as you suggested are below;

I squashed these and looked the result over, but I see it is
contradicting with itself.  You do not want to "publish" a live
git repository so running git-update-server-info in a repository
that is served by this script feels very wrong.

How about having this in contrib/hooks/post-update-worktre?

By the way, there are quite a few careless places that use shell
variables without quoting.

  reply	other threads:[~2007-11-02  8:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02  0:45 [PATCH] post-update hook: update working copy Sam Vilain
2007-11-02  1:02 ` Junio C Hamano
2007-11-02  3:36   ` Sam Vilain
2007-11-02  8:49     ` Junio C Hamano [this message]
2007-11-02 10:34   ` Andreas Ericsson
2007-11-02 17:28     ` Steven Grimm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd4ut58wl.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sam.vilain@catalyst.net.nz \
    --cc=sam@vilain.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.