From: Junio C Hamano <gitster@pobox.com>
To: Sean <seanlkml@sympatico.ca>
Cc: Benoit SIGOURE <tsuna@lrde.epita.fr>, git@vger.kernel.org
Subject: Re: git-svn rebase screwing up commit messages
Date: Sat, 28 Jul 2007 13:41:56 -0700 [thread overview]
Message-ID: <7vd4ycp8ff.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070728101156.20304d11.seanlkml@sympatico.ca> (seanlkml@sympatico.ca's message of "Sat, 28 Jul 2007 10:11:56 -0400")
Sean <seanlkml@sympatico.ca> writes:
> I would argue that you shouldn't try to have it both ways.
You cannot have it both ways as-is, but this is solvable. The
invocation of am from rebase needs an extra (internal to
implementation) option to use the code it patches, and the
regular am can fold what are found on Subject: lines it used
to.
The patch as-is breaks the more important case of e-mail
acceptance codepath, because MUAs are free to fold the Subject:
line when the original line is long, and what the user (the
original patch submitter) expects to happen is that a
single-line-ness of the original Subject: of the message to be
kept. The patch breaks such a line at the place MUA happens to
fold such a long, single line, for comforming messages.
next prev parent reply other threads:[~2007-07-28 20:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-28 10:07 git-svn rebase screwing up commit messages Benoit SIGOURE
2007-07-28 12:14 ` Junio C Hamano
2007-07-28 12:35 ` Sean
2007-07-28 13:10 ` Junio C Hamano
2007-07-28 13:29 ` Sean
2007-07-28 13:38 ` Junio C Hamano
2007-07-28 14:11 ` Sean
2007-07-28 20:41 ` Junio C Hamano [this message]
2007-07-29 1:08 ` Junio C Hamano
2007-07-29 1:10 ` [PATCH 1/3] log_ref_write() -- do not chomp reflog message at the first LF Junio C Hamano
2007-07-29 11:57 ` Johannes Schindelin
2007-07-29 18:47 ` Junio C Hamano
2007-07-29 19:02 ` Johannes Schindelin
2007-07-29 1:10 ` [PATCH 2/3] symbolic-ref, update-ref: do not refuse reflog message with LF Junio C Hamano
2007-07-29 1:11 ` [PATCH 3/3] rebase: try not to munge commit log message Junio C Hamano
2007-07-28 14:32 ` git-svn rebase screwing up commit messages Jakub Narebski
2007-07-28 19:48 ` Robin Rosenberg
2007-07-28 17:33 ` Benoit SIGOURE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4ycp8ff.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=seanlkml@sympatico.ca \
--cc=tsuna@lrde.epita.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.