All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	David Aguilar <davvid@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v2] Do not install shell libraries executable
Date: Sun, 31 Jan 2010 13:08:43 -0800	[thread overview]
Message-ID: <7veil6c78k.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100131210052.GA4435@progeny.tock> (Jonathan Nieder's message of "Sun\, 31 Jan 2010 15\:00\:52 -0600")

Jonathan Nieder <jrnieder@gmail.com> writes:

> I wrote that patch late at night, and unfortunately, I cannot justify it
> to myself now.  With Jeff’s change applied, there is no obvious breakage
> that it fixes.  If a problem comes up again, I will let you know.

Thanks for a thorough write-up.  Really appreciated.

      reply	other threads:[~2010-01-31 21:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28 14:52 [PATCH] rerere: fix too-short initialization Jeff King
2010-01-29 10:25 ` [PATCH 0/3] valgrind bug roundup Jeff King
2010-01-29 10:28   ` [PATCH 1/3] fix memcpy of overlapping area Jeff King
2010-01-29 10:31   ` [PATCH 2/3] fix off-by-one allocation error Jeff King
2010-01-29 10:37   ` [PATCH 3/3] add shebang line to git-mergetool--lib.sh Jeff King
2010-01-29 14:50     ` [PATCH] Do not install shell libraries executable Jonathan Nieder
2010-01-31  7:08       ` Junio C Hamano
2010-01-31  8:34         ` [PATCH v2] " Jonathan Nieder
2010-01-31 19:46           ` Junio C Hamano
2010-01-31 20:00             ` Jonathan Nieder
2010-01-31 20:05               ` Junio C Hamano
2010-01-31 21:00                 ` Jonathan Nieder
2010-01-31 21:08                   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7veil6c78k.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.