From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Alex Riesen <raa.lkml@gmail.com>, git@vger.kernel.org
Subject: Re: bsd group semantics
Date: Tue, 31 Mar 2009 10:32:14 -0700 [thread overview]
Message-ID: <7veiwd61k1.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090331160842.GA9019@coredump.intra.peff.net> (Jeff King's message of "Tue, 31 Mar 2009 12:08:42 -0400")
Jeff King <peff@peff.net> writes:
> On Tue, Mar 31, 2009 at 08:55:00AM -0700, Junio C Hamano wrote:
> ...
>> Ideally the test should be checking if the subdirectory is owned by the
>> same group as the toplevel, but that is rather hard to correctly arrange,
>> as it depends on the set of groups the user who runs the test belongs to,
>> how the git work tree is set up (if it is owned by his primary group or a
>> secondary), etc.
>
> Shouldn't that just be:
>
> perl -e 'sub group { return (stat(shift))[5] }' \
> -e 'exit group($ARGV[0]) == group($ARGV[1]) ? 0 : 1' \
> a b
>
> ?
My point was if I belong only to my personal group and git.git work tree
is owned by junio.junio to begin with, you would never be able to notice
any breakage with such a test.
next prev parent reply other threads:[~2009-03-31 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 11:26 bsd group semantics Jeff King
2009-03-31 15:55 ` Junio C Hamano
2009-03-31 16:08 ` Jeff King
2009-03-31 17:32 ` Junio C Hamano [this message]
2009-03-31 18:46 ` Jeff King
2009-03-31 20:26 ` Junio C Hamano
2009-03-31 20:36 ` Jeff King
2009-03-31 21:33 ` Junio C Hamano
2009-03-31 22:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veiwd61k1.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.